From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBz5R-0003Vs-1q
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 17:05:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBz5N-0003V1-AN
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 17:05:16 -0500
Received: from [199.232.76.173] (port=33785 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBz5N-0003Ur-10
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 17:05:13 -0500
Received: from mail.gmx.net ([213.165.64.20]:33895)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1LBz5M-0003LH-2v
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 17:05:12 -0500
Message-ID: <C13014D1E8734C5E9EE393FD8B4F00A5@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <20081127110220.25353.83454.stgit@dhcp-1-237.tlv.redhat.com><20081127110225.25353.57932.stgit@dhcp-1-237.tlv.redhat.com><20081207025738.GA27991@morn.localdomain>
	<20081209133844.GA5555@redhat.com>
In-Reply-To: <20081209133844.GA5555@redhat.com>
Date: Sun, 14 Dec 2008 23:02:36 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v5 1/5] Add S3 state to
	DSDT.Handle	resume event in the BIOS.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>, bochs-developers@lists.sourceforge.net, Stanislav <stlintel@gmail.com>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org

Gleb Natapov wrote:
> On Sat, Dec 06, 2008 at 09:57:38PM -0500, Kevin O'Connor wrote:
>> Also, wouldn't this corrupt memory used by the stack (the stack gets
>> set to 0xfffe, and s3_post has call insns in it)?
> Here is the patch to set stack pointer to a different value on S3 resume:
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> 
> diff --git a/bios/rombios.c b/bios/rombios.c
> index 7a9c1fd..8e1d3ec 100644
> --- a/bios/rombios.c
> +++ b/bios/rombios.c
> @@ -9114,6 +9114,7 @@ retf_post_0x467:
>   retf
> 
> s3_post:
> +  mov sp, #0xffe
> #if BX_ROMBIOS32
>   call rombios32_init
> #endif

Stanislav, please apply.

- Sebastian