From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1YDeYI-00024L-Ad
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 14:33:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1YDeYC-0000mn-CE
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 14:33:26 -0500
Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:39406)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1YDeYC-0000mX-5u
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 14:33:20 -0500
Received: by mail-qg0-f45.google.com with SMTP id q107so11882290qgd.4
	for <qemu-devel@nongnu.org>; Tue, 20 Jan 2015 11:33:19 -0800 (PST)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Programmingkid <programmingkidx@gmail.com>
In-Reply-To: <CAFEAcA9xVnEARTeMBTOXb006=UhU9OrRWh+-L1c8AvyHwz+uuA@mail.gmail.com>
Date: Tue, 20 Jan 2015 14:33:16 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <C5212DA7-1438-476C-92BB-8C3EB3AE72EF@gmail.com>
References: <F0051F6E-BB68-4155-B947-096191E6C4FA@gmail.com>
	<CAFEAcA9xVnEARTeMBTOXb006=UhU9OrRWh+-L1c8AvyHwz+uuA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] Makes -full-screen option work on Mac
	OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>


On Jan 14, 2015, at 12:09 PM, Peter Maydell wrote:

> On 12 January 2015 at 16:46, Programmingkid =
<programmingkidx@gmail.com> wrote:
>> This patch makes the -full-screen option actually instruct QEMU to =
enter fullscreen at startup.
>>=20
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>>=20
>> ---
>> Removed the set_to_full_screen variable.
>> Removed the scanForFullScreenOption() function.
>>=20
>> ui/cocoa.m |    6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>=20
>> diff --git a/ui/cocoa.m b/ui/cocoa.m
>> index 685081e..4cb07ba 100644
>> --- a/ui/cocoa.m
>> +++ b/ui/cocoa.m
>> @@ -1163,6 +1163,12 @@ void cocoa_display_init(DisplayState *ds, int =
full_screen)
>> {
>>     COCOA_DEBUG("qemu_cocoa: cocoa_display_init\n");
>>=20
>> +    /* if fullscreen mode is to be used */
>> +    if (full_screen =3D=3D true) {
>> +        [NSApp activateIgnoringOtherApps: YES];
>> +        [[[NSApplication sharedApplication] delegate] =
toggleFullScreen: nil];
>> +    }
>> +
>>     dcl =3D g_malloc0(sizeof(DisplayChangeListener));
>>=20
>>     // register vga output callbacks
>=20
> This generates a compile warning for me:
> /Users/pm215/src/qemu/ui/cocoa.m:1150:55: warning: instance method
> '-toggleFullScreen:' not found (return type defaults to 'id')
>      [-Wobjc-method-access]
>        [[[NSApplication sharedApplication] delegate] toggleFullScreen: =
nil];
>                                                      ^~~~~~~~~~~~~~~~

Would you accept a patch that eliminated this warning by disabling
-Wobjc-method-access?=20

The problem is Objective-C classes usually are in two files, the=20
header and the .m file. Cocoa.m places both the interface and
implementation of the QemuCocoaAppController in one file,=20
so that is why I think we are seeing this message.