Re: [PATCH v3 03/10] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines

[Nabih Estefan <nabihestefan@google.com>]

On Tue, Apr 15, 2025 at 8:43 PM Jamin Lin <jamin_lin@aspeedtech.com> wrote:
>
> Introduce a new "vbootrom" field in the AspeedMachineClass to indicate whether
> a machine supports the virtual boot ROM region.
>
> Set this field to true by default for the AST2700-A0 and AST2700-A1 EVB
> machines.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Nabih Estefan <nabihestefan@google.com>
Tested-by: Nabih Estefan <nabihestefan@google.com>

> ---
>  include/hw/arm/aspeed.h | 1 +
>  hw/arm/aspeed.c         | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
> index 9cae45a1c9..973277bea6 100644
> --- a/include/hw/arm/aspeed.h
> +++ b/include/hw/arm/aspeed.h
> @@ -40,6 +40,7 @@ struct AspeedMachineClass {
>      void (*i2c_init)(AspeedMachineState *bmc);
>      uint32_t uart_default;
>      bool sdhci_wp_inverted;
> +    bool vbootrom;
>  };
>
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 82f42582fa..e852bbc4cb 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -1689,6 +1689,7 @@ static void aspeed_machine_ast2700a0_evb_class_init(ObjectClass *oc, void *data)
>      amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON | ASPEED_MAC2_ON;
>      amc->uart_default = ASPEED_DEV_UART12;
>      amc->i2c_init  = ast2700_evb_i2c_init;
> +    amc->vbootrom = true;
>      mc->auto_create_sdcard = true;
>      mc->default_ram_size = 1 * GiB;
>      aspeed_machine_class_init_cpus_defaults(mc);
> @@ -1709,6 +1710,7 @@ static void aspeed_machine_ast2700a1_evb_class_init(ObjectClass *oc, void *data)
>      amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON | ASPEED_MAC2_ON;
>      amc->uart_default = ASPEED_DEV_UART12;
>      amc->i2c_init  = ast2700_evb_i2c_init;
> +    amc->vbootrom = true;
>      mc->auto_create_sdcard = true;
>      mc->default_ram_size = 1 * GiB;
>      aspeed_machine_class_init_cpus_defaults(mc);
> --
> 2.43.0
>