From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2F43D3B7E2 for ; Mon, 8 Dec 2025 18:22:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vSfrl-0001LZ-EM; Mon, 08 Dec 2025 13:21:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vSfrj-0001L2-CZ for qemu-devel@nongnu.org; Mon, 08 Dec 2025 13:21:43 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vSfrh-0000gk-NA for qemu-devel@nongnu.org; Mon, 08 Dec 2025 13:21:43 -0500 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-4ee147baf7bso22551cf.1 for ; Mon, 08 Dec 2025 10:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765218099; x=1765822899; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GegoaMD4IBYBNAojeiyyUljTu2SnAHNz/bqQ2Tbdcf4=; b=EA8e4llnYZQe5kD7JXNV9RKwiPxX/jX5de4weJB0wqxKrYrDCmHUlcKpws3ZWdVjRI 4pAmkI/jN0Eakryx3k37QdpHjbCMjUWgjwJ+RQC6yGvT1iO5wq5ZATh6V3RRRo2/pyEF 7YnpqBzvtiZcqsPDnQGPIrjmGbl7HRg4lPSWg5JmVsZVLxN61BNQnmZRPRVcpPZ01ILl SzPNaizzrM7kg7aEsN7Ucb2xWMZ7t/JmTgc1iM3d1vp0nyawif9Z8OKZqtdF5ER9xVQC Uuikf8AlbiMLfDwV5Hq6xKBCGxY/ihmGTyYRPs2qur0AZKOO+X0ByNpQCo/palx0G9ZQ XPNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765218099; x=1765822899; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GegoaMD4IBYBNAojeiyyUljTu2SnAHNz/bqQ2Tbdcf4=; b=IItcyUho8bWbZwhzruiShxF+TBVSb1OsGpTbOyt86Wt3szlrSYK2mIfw79XuZHcGl3 qd1lRlRDXGlTKWNg0evxjK/1vPOIjhSXuGNycP8mfoWrkTcpjdsK1l8Dir+S940tSgd9 YGUOXKDHs3WcThPftqjbeRm45Yt+lqDa2VqNsJ2z3AqWEf6z/OTIKGLsrDzulgYGpQCa 7TSiiCmJeyQokTzRwovGfPZWFJ92IU1xZ5yENZ1StDbcRe3F1X7U0GWSYYMW1ovXDK7P q+87r2W+QiG9rWWhwH0hmDZP96l8T3PC3LMxALbM62erLnoLsNEhvorV1PICNXL+jAAW +B6w== X-Forwarded-Encrypted: i=1; AJvYcCV3dsf48VwqOOU8qy4d5MUKzW9xDd0EnL2X34WIcGXRHrB+ZDNGBJRG6EuhVVetKZI63KSWaZgTE50K@nongnu.org X-Gm-Message-State: AOJu0YxLvGYhe+t5CBxowlkwZ6FcnKSk/OUDtuQTJWIAbjfI6EWoC7MW s1OQ5/DV0O+43TCy+mGsUUO2o8JOzwXsJJ+AwK0Um+vMIWrgSdc1W3HcO7SS5+ohG+EpdxwofcQ Wheb1PHroe0b8L0qBDmRxH3bAw1qjp0qTibl/WtTC X-Gm-Gg: ASbGncviDs1C7d0KCmtkUGC5pl71vPSwRNK9saY6PQrAahsdZRshPuVE2z+m89X/7tP 2r86gxOJ4h6LXq4NKSmGiyLMAlGUlGeWn6eyXMobxdqK994dNMNCC4HkzX4zy2LtWFihF/L96pJ J1Wp0inXvPz+3MirYIeTwnDEw3kF0XPCj8aEhDz2k5W+tWkJpWWu1Ffu7OpFtFjCI6B6grPP30M 0jc0oFH6q251P9CEeek3vP09pazAnvxStKNbuuOhlb+6+tgtgKiWU7sSx6zJnt64YZtA+XUfuXx QEhekiNqkf2cpSTeD+vOhJT8Ew== X-Google-Smtp-Source: AGHT+IF0d6Grur514sbwezzzvoHr3zDGB1sIe8vg3mNqeZJigmwuRQ/HvmsJI3sYYXQ2BQDq3VCiN5NIAZZ6fKii8PY= X-Received: by 2002:a05:622a:8c0b:b0:4f0:2e33:81aa with SMTP id d75a77b69052e-4f1a50cebe6mr129061cf.11.1765218098803; Mon, 08 Dec 2025 10:21:38 -0800 (PST) MIME-Version: 1.0 References: <20251208074436.1871180-1-kane_chen@aspeedtech.com> <20251208074436.1871180-18-kane_chen@aspeedtech.com> In-Reply-To: <20251208074436.1871180-18-kane_chen@aspeedtech.com> From: Nabih Estefan Date: Mon, 8 Dec 2025 10:21:27 -0800 X-Gm-Features: AQt7F2qF_pgj6RrViDlozXX_E7WkTMzPcE5whutxjgby_SkfLGxzznkl3wXsC7Q Message-ID: Subject: Re: [PATCH v3 17/18] hw/arm/aspeed: Attach SGPIOM device to AST1700 model To: Kane Chen Cc: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" , troy_lee@aspeedtech.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=nabihestefan@google.com; helo=mail-qt1-x831.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Dec 7, 2025 at 11:48=E2=80=AFPM Kane Chen via wrote: > > From: Kane-Chen-AS > > Connect the SGPIOM device to AST1700 model. > > Signed-off-by: Kane-Chen-AS > --- > include/hw/arm/aspeed_ast1700.h | 3 +++ > hw/arm/aspeed_ast1700.c | 20 ++++++++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast1= 700.h > index 7292719dc2..490f2a3b05 100644 > --- a/include/hw/arm/aspeed_ast1700.h > +++ b/include/hw/arm/aspeed_ast1700.h > @@ -12,6 +12,7 @@ > #include "hw/misc/aspeed_scu.h" > #include "hw/adc/aspeed_adc.h" > #include "hw/gpio/aspeed_gpio.h" > +#include "hw/gpio/aspeed_sgpio.h" As far as I can tell this depends on Yubin Zou's SGPIO series (link below)? Does that mean the series looks good? Can you reply to the series itself if it is? https://lore.kernel.org//qemu-devel/20251106-aspeed-sgpio-v1-0-b026093716f= a@google.com > #include "hw/i2c/aspeed_i2c.h" > #include "hw/misc/aspeed_ltpi.h" > #include "hw/misc/aspeed_pwm.h" > @@ -19,6 +20,7 @@ > #include "hw/watchdog/wdt_aspeed.h" > #include "hw/char/serial-mm.h" > > +#define AST1700_SGPIO_NUM 2 > #define AST1700_WDT_NUM 9 > > #define TYPE_ASPEED_AST1700 "aspeed.ast1700" > @@ -39,6 +41,7 @@ struct AspeedAST1700SoCState { > AspeedADCState adc; > AspeedSCUState scu; > AspeedGPIOState gpio; > + AspeedSGPIOState sgpiom[AST1700_SGPIO_NUM]; > AspeedI2CState i2c; > AspeedPWMState pwm; > AspeedWDTState wdt[AST1700_WDT_NUM]; > diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c > index c9d7a97a80..e027ae02ad 100644 > --- a/hw/arm/aspeed_ast1700.c > +++ b/hw/arm/aspeed_ast1700.c > @@ -23,6 +23,8 @@ enum { > ASPEED_AST1700_DEV_ADC, > ASPEED_AST1700_DEV_SCU, > ASPEED_AST1700_DEV_GPIO, > + ASPEED_AST1700_DEV_SGPIOM0, > + ASPEED_AST1700_DEV_SGPIOM1, > ASPEED_AST1700_DEV_I2C, > ASPEED_AST1700_DEV_UART12, > ASPEED_AST1700_DEV_LTPI_CTRL, > @@ -37,6 +39,8 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { > [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, > [ASPEED_AST1700_DEV_SCU] =3D 0x00C02000, > [ASPEED_AST1700_DEV_GPIO] =3D 0x00C0B000, > + [ASPEED_AST1700_DEV_SGPIOM0] =3D 0x00C0C000, > + [ASPEED_AST1700_DEV_SGPIOM1] =3D 0x00C0D000, > [ASPEED_AST1700_DEV_I2C] =3D 0x00C0F000, > [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, > [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, > @@ -142,6 +146,16 @@ static void aspeed_ast1700_realize(DeviceState *dev,= Error **errp) > aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_LTPI= _CTRL], > sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->ltpi),= 0)); > > + /* SGPIOM */ > + for (int i =3D 0; i < AST1700_SGPIO_NUM; i++) { > + if (!sysbus_realize(SYS_BUS_DEVICE(&s->sgpiom[i]), errp)) { > + return; > + } > + memory_region_add_subregion(&s->iomem, > + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SGPIOM0 = + i], > + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->sgpiom[i])= , 0)); > + } > + > /* WDT */ > for (int i =3D 0; i < AST1700_WDT_NUM; i++) { > AspeedWDTClass *awc =3D ASPEED_WDT_GET_CLASS(&s->wdt[i]); > @@ -194,6 +208,12 @@ static void aspeed_ast1700_instance_init(Object *obj= ) > object_initialize_child(obj, "ltpi-ctrl", > &s->ltpi, TYPE_ASPEED_LTPI); > > + /* SGPIOM */ > + for (int i =3D 0; i < AST1700_SGPIO_NUM; i++) { > + object_initialize_child(obj, "ioexp-sgpiom[*]", &s->sgpiom[i], > + "aspeed.sgpio-ast2700"); > + } > + > /* WDT */ > for (int i =3D 0; i < AST1700_WDT_NUM; i++) { > object_initialize_child(obj, "ioexp-wdt[*]", > -- > 2.43.0 > >