* [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]
@ 2020-09-14 19:05 Stefano Garzarella
2020-09-14 19:15 ` Jason Dillaman
2020-09-15 9:04 ` Max Reitz
0 siblings, 2 replies; 3+ messages in thread
From: Stefano Garzarella @ 2020-09-14 19:05 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Florian Florensa, Jason Dillaman, qemu-block,
Max Reitz
Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
introduced namespace support for RBD, but we forgot to add the
new 'namespace' options to qemu_rbd_strong_runtime_opts[].
The 'namespace' is used to identify the image, so it is a strong
option since it can changes the data of a BDS.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1821528
Fixes: 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
Cc: Florian Florensa <fflorensa@online.net>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
block/rbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/rbd.c b/block/rbd.c
index 688074c64b..5356753fbe 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1289,6 +1289,7 @@ static QemuOptsList qemu_rbd_create_opts = {
static const char *const qemu_rbd_strong_runtime_opts[] = {
"pool",
+ "namespace",
"image",
"conf",
"snapshot",
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]
2020-09-14 19:05 [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[] Stefano Garzarella
@ 2020-09-14 19:15 ` Jason Dillaman
2020-09-15 9:04 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Jason Dillaman @ 2020-09-14 19:15 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Kevin Wolf, qemu-block, qemu-devel, Max Reitz, Florian Florensa,
Jason Dillaman
On Mon, Sep 14, 2020 at 3:06 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> introduced namespace support for RBD, but we forgot to add the
> new 'namespace' options to qemu_rbd_strong_runtime_opts[].
>
> The 'namespace' is used to identify the image, so it is a strong
> option since it can changes the data of a BDS.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1821528
> Fixes: 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> Cc: Florian Florensa <fflorensa@online.net>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 688074c64b..5356753fbe 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -1289,6 +1289,7 @@ static QemuOptsList qemu_rbd_create_opts = {
>
> static const char *const qemu_rbd_strong_runtime_opts[] = {
> "pool",
> + "namespace",
> "image",
> "conf",
> "snapshot",
> --
> 2.26.2
>
lgtm
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
--
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]
2020-09-14 19:05 [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[] Stefano Garzarella
2020-09-14 19:15 ` Jason Dillaman
@ 2020-09-15 9:04 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2020-09-15 9:04 UTC (permalink / raw)
To: Stefano Garzarella, qemu-devel
Cc: Kevin Wolf, Florian Florensa, Jason Dillaman, qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]
On 14.09.20 21:05, Stefano Garzarella wrote:
> Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> introduced namespace support for RBD, but we forgot to add the
> new 'namespace' options to qemu_rbd_strong_runtime_opts[].
>
> The 'namespace' is used to identify the image, so it is a strong
> option since it can changes the data of a BDS.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1821528
> Fixes: 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> Cc: Florian Florensa <fflorensa@online.net>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-15 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-14 19:05 [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[] Stefano Garzarella
2020-09-14 19:15 ` Jason Dillaman
2020-09-15 9:04 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).