From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nathan@nathanrossi.com>) id 1aRg8I-00051D-GA
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 08:09:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nathan@nathanrossi.com>) id 1aRg8H-0008S1-IZ
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 08:09:06 -0500
Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:33486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nathan@nathanrossi.com>) id 1aRg8H-0008Rt-9f
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 08:09:05 -0500
Received: by mail-lf0-x22c.google.com with SMTP id m1so57635660lfg.0
	for <qemu-devel@nongnu.org>; Fri, 05 Feb 2016 05:09:05 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <96bfa9b8d822c77e600c3d5b5ded500593ba5057.1454545837.git.alistair.francis@xilinx.com>
References: <cover.1454545837.git.alistair.francis@xilinx.com>
	<96bfa9b8d822c77e600c3d5b5ded500593ba5057.1454545837.git.alistair.francis@xilinx.com>
Date: Fri, 5 Feb 2016 23:09:04 +1000
Message-ID: <CA+aJhH23WupxH0N92BVV5KpCSMYc5ByLSDnTmH2bCDL9MMwnkg@mail.gmail.com>
From: Nathan Rossi <nathan@nathanrossi.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v1 3/3] target-arm: Add the pmovsclr_el0
 and pmintenclr_el1 registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.maydell@linaro.org, Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org, alindsay@codeaurora.org, cov@codeaurora.org

On Thu, Feb 4, 2016 at 10:34 AM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>

Tested-by: Nathan Rossi <nathan@nathanrossi.com>

> ---
>
>  target-arm/helper.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 2e0018c..c3fa57d 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -1031,6 +1031,13 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
>        .accessfn = pmreg_access,
>        .writefn = pmovsr_write,
>        .raw_writefn = raw_write },
> +    { .name = "PMOVSCLR_EL0", .state = ARM_CP_STATE_AA64,
> +      .opc0 = 3, .opc1 = 3, .crn = 9, .crm = 12, .opc2 = 3,
> +      .access = PL0_RW, .accessfn = pmreg_access,
> +      .type = ARM_CP_ALIAS,
> +      .fieldoffset = offsetof(CPUARMState, cp15.c9_pmovsr),
> +      .writefn = pmovsr_write,
> +      .raw_writefn = raw_write },
>      /* Unimplemented so WI. */
>      { .name = "PMSWINC", .cp = 15, .crn = 9, .crm = 12, .opc1 = 0, .opc2 = 4,
>        .access = PL0_W, .accessfn = pmreg_access, .type = ARM_CP_NOP },
> @@ -1096,6 +1103,11 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
>        .access = PL1_RW, .type = ARM_CP_ALIAS,
>        .fieldoffset = offsetof(CPUARMState, cp15.c9_pminten),
>        .writefn = pmintenclr_write, },
> +    { .name = "PMINTENCLR_EL1", .state = ARM_CP_STATE_AA64,
> +      .opc0 = 3, .opc1 = 0, .crn = 9, .crm = 14, .opc2 = 2,
> +      .access = PL1_RW, .type = ARM_CP_ALIAS,
> +      .fieldoffset = offsetof(CPUARMState, cp15.c9_pminten),
> +      .writefn = pmintenclr_write },
>      { .name = "VBAR", .state = ARM_CP_STATE_BOTH,
>        .opc0 = 3, .crn = 12, .crm = 0, .opc1 = 0, .opc2 = 0,
>        .access = PL1_RW, .writefn = vbar_write,
> --
> 2.5.0
>