From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5023DC47096 for ; Thu, 3 Jun 2021 15:11:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BC836139A for ; Thu, 3 Jun 2021 15:11:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BC836139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lop0g-0005oX-J5 for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 11:11:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loozV-0004Rz-Nr for qemu-devel@nongnu.org; Thu, 03 Jun 2021 11:10:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loozT-0005R7-21 for qemu-devel@nongnu.org; Thu, 03 Jun 2021 11:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622733033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r8y0AvcHRCELm6t/Y7P+BjVBOZqRiYHk7yUx7sxCtpU=; b=Q3UV1fh3r8PwxZHU8ghXlKKOqXfioCjl3ygOLSBUfZPzduXDFxjEgdRQ90Yvp+lf8/da/T b8oCOM1/RryEWQ5yUgjdesu6uwC/GVsaJruzlKpHEVAxZjNmxGKprcU72PbmjxYf+1LA61 ehuhe1pseIhxEr0/CcLfPNmSiX0phEA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-oAXHGHOAPf20_wIfCwdhUQ-1; Thu, 03 Jun 2021 11:10:30 -0400 X-MC-Unique: oAXHGHOAPf20_wIfCwdhUQ-1 Received: by mail-ed1-f72.google.com with SMTP id df3-20020a05640230a3b029039179c0f290so1739425edb.13 for ; Thu, 03 Jun 2021 08:10:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r8y0AvcHRCELm6t/Y7P+BjVBOZqRiYHk7yUx7sxCtpU=; b=Z1u89bRZPuh0ep/yVNyX9DltU2reUEstIcu+2Ukf9XQ4X8XP1bsvJKILV1VUzi+myk 7xN+l/1xu5rQu2QuqXVt62cIkCYINBN8syUet1NnBZDJAwEP6JFjdGEhKIE/J6SwTH4N ZmrGKwm9QV3tFu68ki4XUlMTmLOhqLvDNZTdACvNEHXa0nT/aNUsjCChJ5SD1p8KN7Tp paTNThMlXK2SzvRwa/1zFXgD8B8MWAh4QID2KT0e5N993IkCGtEQfxUPXScnDLNGHyrR vzWDFdnCrXow5Gc542d4uOu/xOkECOOzVjKEIMXLhY9wcQTYhhl7H0FS3zlGbHdncHww qjfA== X-Gm-Message-State: AOAM533HcoEJprDSq1KACbRxGS3t8jsoPMhvFYk5bAcXH8+YFYqYhcqa 4VpXdSaZJrbII4mcwof4K7hBHUy2K6vlpSdo2i+UPhS7YYv56To6gZoJsLGsBdXWyXBoYiLEWj4 2U4I8XHBBaC/F7FkUYYZY4G99s56z168= X-Received: by 2002:a17:906:5049:: with SMTP id e9mr92442ejk.30.1622733029718; Thu, 03 Jun 2021 08:10:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXExNHlLRtb/OkWZpkOmOaNpXpFo8+ae0qrvE/zQ9qIkCSJWcNHLOqSmhPcUrpGrQW1q721OTF9ztEbGKzpqU= X-Received: by 2002:a17:906:5049:: with SMTP id e9mr92419ejk.30.1622733029525; Thu, 03 Jun 2021 08:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20210603123001.17843-1-cfontana@suse.de> <1da75e95-1255-652e-1ca3-d23a8f6bf392@suse.de> In-Reply-To: <1da75e95-1255-652e-1ca3-d23a8f6bf392@suse.de> From: Cleber Rosa Junior Date: Thu, 3 Jun 2021 11:10:17 -0400 Message-ID: Subject: Re: [PATCH v2 0/2] Fixes for "Windows fails to boot" To: Claudio Fontana Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000ca5e5105c3ddf91e" Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.37, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Marcelo Tosatti , Eduardo Habkost , kvm@vger.kernel.org, Siddharth Chandrasekaran , "Michael S . Tsirkin" , Richard Henderson , qemu-devel , Cameron Esfahani , Roman Bolshakov , Paolo Bonzini , Vitaly Kuznetsov , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000ca5e5105c3ddf91e Content-Type: text/plain; charset="UTF-8" On Thu, Jun 3, 2021 at 10:29 AM Claudio Fontana wrote: > On 6/3/21 2:29 PM, Claudio Fontana wrote: > > v1 -> v2: > > * moved hyperv realizefn call before cpu expansion (Vitaly) > > * added more comments (Eduardo) > > * fixed references to commit ids (Eduardo) > > > > The combination of Commits: > > f5cc5a5c ("i386: split cpu accelerators from cpu.c"...) > > > 30565f10 ("cpu: call AccelCPUClass::cpu_realizefn in"...) > > > > introduced two bugs that break cpu max and host in the refactoring, > > by running initializations in the wrong order. > > > > This small series of two patches is an attempt to correct the situation. > > > > Please provide your test results and feedback, thanks! > > > > Claudio > > > > Claudio Fontana (2): > > i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn > > i386: run accel_cpu_instance_init as instance_post_init > > > > target/i386/cpu.c | 89 +++++++++++++++++++++++++-------------- > > target/i386/kvm/kvm-cpu.c | 12 +++++- > > 2 files changed, 68 insertions(+), 33 deletions(-) > > > > Btw, CI/CD is all green, but as mentioned, it does not seem to catch these > kind of issues. > > Hi Claudio, Not familiar with the specifics of this bug, but can it be caught by attempting to boot an image other than Windows? If so, we can consider adding a test along the lines of tests/acceptance/boot_linux_console.py. Thanks, - Cleber. > https://gitlab.com/hw-claudio/qemu/-/pipelines/314286751 > > C. > > > --000000000000ca5e5105c3ddf91e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Jun 3, 2021 at 10:29 AM Claud= io Fontana <cfontana@suse.de>= wrote:
On 6/3/2= 1 2:29 PM, Claudio Fontana wrote:
> v1 -> v2:
>=C2=A0 * moved hyperv realizefn call before cpu expansion (Vitaly)
>=C2=A0 * added more comments (Eduardo)
>=C2=A0 * fixed references to commit ids (Eduardo)
>
> The combination of Commits:
> f5cc5a5c ("i386: split cpu accelerators from cpu.c"...)=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
> 30565f10 ("cpu: call AccelCPUClass::cpu_realizefn in"...) >
> introduced two bugs that break cpu max and host in the refactoring, > by running initializations in the wrong order.
>
> This small series of two patches is an attempt to correct the situatio= n.
>
> Please provide your test results and feedback, thanks!
>
> Claudio
>
> Claudio Fontana (2):
>=C2=A0 =C2=A0i386: reorder call to cpu_exec_realizefn in x86_cpu_realiz= efn
>=C2=A0 =C2=A0i386: run accel_cpu_instance_init as instance_post_init >
>=C2=A0 target/i386/cpu.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 89 ++++++++= +++++++++++++++++--------------
>=C2=A0 target/i386/kvm/kvm-cpu.c | 12 +++++-
>=C2=A0 2 files changed, 68 insertions(+), 33 deletions(-)
>

Btw, CI/CD is all green, but as mentioned, it does not seem to catch these = kind of issues.


Hi Claudio,

N= ot familiar with the specifics of this bug, but can it be caught by attempt= ing to boot an image other than Windows?=C2=A0 If so, we can consider addin= g a test along the lines of tests/acceptance/boot_linux_console.py.

Thanks,
- Cleber.=C2=A0=C2=A0=C2=A0
= =C2=A0
https://gitlab.com/hw-claudio/qemu/-/pipelin= es/314286751

C.


--000000000000ca5e5105c3ddf91e--