Re: [PATCH v2] Adding new machine Tiogapass in QEMU

[karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 6316 bytes --]

Noted.

Thanks,
Cédric


On Fri, Feb 17, 2023 at 1:19 PM Cédric Le Goater <clg@kaod.org> wrote:

> Hello Karthikeyan,
>
> On 2/16/23 19:43, Karthikeyan Pasupathi wrote:
> > This patch support Tiogapass in QEMU environment.
> > and introduced EEPROM BMC FRU data support "add tiogapass_bmc_fruid data"
> > along with the machine support.
> >
> > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
>
> There are a couple of coding style issues that I will fix. This is minor.
> (./scripts/checkpatch.pl is a good tool to run before sending.)
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
> Thanks,
>
> C.
>
> > ---
> >   hw/arm/aspeed.c        | 32 ++++++++++++++++++++++++++++++++
> >   hw/arm/aspeed_eeprom.c | 22 ++++++++++++++++++++++
> >   hw/arm/aspeed_eeprom.h |  3 +++
> >   3 files changed, 57 insertions(+)
> >
> > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> > index 27dda58338..d12164420d 100644
> > --- a/hw/arm/aspeed.c
> > +++ b/hw/arm/aspeed.c
> > @@ -530,6 +530,15 @@ static void romulus_bmc_i2c_init(AspeedMachineState
> *bmc)
> >       i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 11),
> "ds1338", 0x32);
> >   }
> >
> > +static void tiogapass_bmc_i2c_init(AspeedMachineState *bmc)
> > +{
> > +    AspeedSoCState *soc = &bmc->soc;
> > +
> > +    at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 4), 0x54, 128 *
> KiB);
> > +    at24c_eeprom_init_rom(aspeed_i2c_get_bus(&soc->i2c, 6), 0x54, 128 *
> KiB, tiogapass_bmc_fruid,
> > +                          tiogapass_bmc_fruid_len);
> > +}
> > +
> >   static void create_pca9552(AspeedSoCState *soc, int bus_id, int addr)
> >   {
> >       i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, bus_id),
> > @@ -1191,6 +1200,25 @@ static void
> aspeed_machine_romulus_class_init(ObjectClass *oc, void *data)
> >           aspeed_soc_num_cpus(amc->soc_name);
> >   };
> >
> > +static void aspeed_machine_tiogapass_class_init(ObjectClass *oc, void
> *data)
> > +{
> > +    MachineClass *mc = MACHINE_CLASS(oc);
> > +    AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
> > +
> > +    mc->desc       = "Facebook Tiogapass BMC (ARM1176)";
> > +    amc->soc_name  = "ast2500-a1";
> > +    amc->hw_strap1 = AST2500_EVB_HW_STRAP1;
> > +    amc->hw_strap2 = 0;
> > +    amc->fmc_model = "n25q256a";
> > +    amc->spi_model = "mx25l25635e";
> > +    amc->num_cs    = 2;
> > +    amc->i2c_init  = tiogapass_bmc_i2c_init;
> > +    mc->default_ram_size       = 1 * GiB;
> > +    mc->default_cpus = mc->min_cpus = mc->max_cpus =
> > +        aspeed_soc_num_cpus(amc->soc_name);
> > +        aspeed_soc_num_cpus(amc->soc_name);
> > +};
> > +
> >   static void aspeed_machine_sonorapass_class_init(ObjectClass *oc, void
> *data)
> >   {
> >       MachineClass *mc = MACHINE_CLASS(oc);
> > @@ -1566,6 +1594,10 @@ static const TypeInfo aspeed_machine_types[] = {
> >           .name          = MACHINE_TYPE_NAME("tacoma-bmc"),
> >           .parent        = TYPE_ASPEED_MACHINE,
> >           .class_init    = aspeed_machine_tacoma_class_init,
> > +    }, {
> > +        .name          = MACHINE_TYPE_NAME("tiogapass-bmc"),
> > +        .parent        = TYPE_ASPEED_MACHINE,
> > +        .class_init    = aspeed_machine_tiogapass_class_init,
> >       }, {
> >           .name          = MACHINE_TYPE_NAME("g220a-bmc"),
> >           .parent        = TYPE_ASPEED_MACHINE,
> > diff --git a/hw/arm/aspeed_eeprom.c b/hw/arm/aspeed_eeprom.c
> > index 04463acc9d..f937a6ceaa 100644
> > --- a/hw/arm/aspeed_eeprom.c
> > +++ b/hw/arm/aspeed_eeprom.c
> > @@ -6,6 +6,27 @@
> >
> >   #include "aspeed_eeprom.h"
> >
> > +/* Tiogapass BMC FRU */
> > +const uint8_t tiogapass_bmc_fruid[] = {
> > +    0x01, 0x00, 0x00, 0x01, 0x0d, 0x00, 0x00, 0xf1, 0x01, 0x0c, 0x00,
> 0x36,
> > +    0xe6, 0xd0, 0xc6, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, 0x42,
> 0x4d,
> > +    0x43, 0x20, 0x53, 0x74, 0x6f, 0x72, 0x61, 0x67, 0x65, 0x20, 0x4d,
> 0x6f,
> > +    0x64, 0x75, 0x6c, 0x65, 0xcd, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58,
> 0x58,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xce, 0x58, 0x58, 0x58, 0x58,
> 0x58,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc3, 0x31,
> 0x2e,
> > +    0x30, 0xc9, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58,
> 0xd2,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58,
> 0x58,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc1, 0x39, 0x01, 0x0c, 0x00,
> 0xc6,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, 0x54, 0x69, 0x6f, 0x67,
> 0x61,
> > +    0x20, 0x50, 0x61, 0x73, 0x73, 0x20, 0x53, 0x69, 0x6e, 0x67, 0x6c,
> 0x65,
> > +    0x32, 0xce, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58,
> 0x58,
> > +    0x58, 0x58, 0x58, 0x58, 0xc4, 0x58, 0x58, 0x58, 0x32, 0xcd, 0x58,
> 0x58,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58,
> 0xc7,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc3, 0x31, 0x2e, 0x30,
> 0xc9,
> > +    0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc8, 0x43,
> 0x6f,
> > +    0x6e, 0x66, 0x69, 0x67, 0x20, 0x41, 0xc1, 0x45,
> > +};
> > +
> >   const uint8_t fby35_nic_fruid[] = {
> >       0x01, 0x00, 0x00, 0x01, 0x0f, 0x20, 0x00, 0xcf, 0x01, 0x0e, 0x19,
> 0xd7,
> >       0x5e, 0xcf, 0xc8, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58,
> 0xdd,
> > @@ -77,6 +98,7 @@ const uint8_t fby35_bmc_fruid[] = {
> >       0x6e, 0x66, 0x69, 0x67, 0x20, 0x41, 0xc1, 0x45,
> >   };
> >
> > +const size_t tiogapass_bmc_fruid_len = sizeof(tiogapass_bmc_fruid);
> >   const size_t fby35_nic_fruid_len = sizeof(fby35_nic_fruid);
> >   const size_t fby35_bb_fruid_len = sizeof(fby35_bb_fruid);
> >   const size_t fby35_bmc_fruid_len = sizeof(fby35_bmc_fruid);
> > diff --git a/hw/arm/aspeed_eeprom.h b/hw/arm/aspeed_eeprom.h
> > index a0f848fa6e..69db103c83 100644
> > --- a/hw/arm/aspeed_eeprom.h
> > +++ b/hw/arm/aspeed_eeprom.h
> > @@ -9,6 +9,9 @@
> >
> >   #include "qemu/osdep.h"
> >
> > +extern const uint8_t tiogapass_bmc_fruid[];
> > +extern const size_t tiogapass_bmc_fruid_len;
> > +
> >   extern const uint8_t fby35_nic_fruid[];
> >   extern const uint8_t fby35_bb_fruid[];
> >   extern const uint8_t fby35_bmc_fruid[];
>
>

[-- Attachment #2: Type: text/html, Size: 7883 bytes --]