From: Dehan Meng <demeng@redhat.com>
To: Konstantin Kostiuk <kkostiuk@redhat.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com
Subject: Re: [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command
Date: Thu, 22 Feb 2024 10:56:03 +0800 [thread overview]
Message-ID: <CA+kPPJweQkm50+6q4uYx33kU8kc-u13TbkhqEO+CL3VHht18CQ@mail.gmail.com> (raw)
In-Reply-To: <CAPMcbCr9y89BiM+mTF3i2n6GfAA9Xnu3ovoS-KamLZFEiAhrSA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
Done. thanks.
On Wed, Feb 21, 2024 at 6:00 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:
>
>
> On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng <demeng@redhat.com> wrote:
>
>> Add support of Windows Server 2025 in get-osinfo command
>>
>> Signed-off-by: Dehan Meng <demeng@redhat.com>
>> ---
>> qga/commands-win32.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
>> index 697c65507c..f3c7e604c9 100644
>> --- a/qga/commands-win32.c
>> +++ b/qga/commands-win32.c
>> @@ -2154,6 +2154,7 @@ static ga_win_10_0_t const
>> WIN_10_0_SERVER_VERSION_MATRIX[4] = {
>>
>
> You don't update the array size, there are out of range elements
>
>
>> {14393, "Microsoft Windows Server 2016", "2016"},
>> {17763, "Microsoft Windows Server 2019", "2019"},
>> {20344, "Microsoft Windows Server 2022", "2022"},
>> + {26040, "MIcrosoft Windows Server 2025", "2025"},
>> {0, 0}
>> };
>>
>> --
>> 2.35.1
>>
>>
[-- Attachment #2: Type: text/html, Size: 1962 bytes --]
prev parent reply other threads:[~2024-02-22 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 9:51 [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command Dehan Meng
2024-02-21 10:00 ` Konstantin Kostiuk
2024-02-22 2:56 ` Dehan Meng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+kPPJweQkm50+6q4uYx33kU8kc-u13TbkhqEO+CL3VHht18CQ@mail.gmail.com \
--to=demeng@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).