From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3DBC004C9 for ; Tue, 7 May 2019 19:55:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49C2020825 for ; Tue, 7 May 2019 19:55:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="F6ld+tZI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49C2020825 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:52696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO6Br-00032t-BV for qemu-devel@archiver.kernel.org; Tue, 07 May 2019 15:55:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO5ho-0004e9-KG for qemu-devel@nongnu.org; Tue, 07 May 2019 15:24:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO5hn-0004hs-Rw for qemu-devel@nongnu.org; Tue, 07 May 2019 15:24:48 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:35600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hO5hn-0004em-I7 for qemu-devel@nongnu.org; Tue, 07 May 2019 15:24:47 -0400 Received: by mail-lf1-x132.google.com with SMTP id j20so12715497lfh.2 for ; Tue, 07 May 2019 12:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=F6ld+tZIKD1TRL0AE6fEb2WqRxcP76uZx0RNPDleIxyf5RJkwYPqK0Bs9zD4aODmmE 4NNavp1nVKPc4olfZNB0csbl8Mt2jrfw/4cvqI1dQpb6hDyRxWSjJ7Yy4Q29HBvFbOfA JtYubFLJeY+4ZpX9T0ONIWuycTh2DIrMPc1SCGpQzEDby6c9B7ZikuGkc84pDR1T+N6M 9spwBfJp4nacEIzecHYOyudxpJIHO5m/IUkW4JFPQf66ZbDiyfZVU/nw8vjKyLhqtWer 9FWQL1ENLRVadfjFY2rI1CERtp+W1p4k6aV0bmDTRupY82fFnsyC2IcEpAqT8PcIv623 jo8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=R4+5Hhl2zHfHoqRVQ4wgpfsi/9O8l38yP1Pf9By7bX2W+zq2ULf1emzuzX2vzEwNQb dvZVgbIBczIYXdp6M0Jqp3dmmnKm5CvoJPuNAa1jPzyZVTFuNZGWdXMBPOu06S01FO8m S6stuS6uKj4mS8l51wLmYHxgMjAlGOUpsgAHk3EPmzf6Ur0T2L5ZcImQWEUY9LRC+RUj aaNudwpKWQfMWbCurd8wz/r+O4xgfvJUVwRy7H7N5rOlIO18OqKhGpWspMirmyyFHZZS XSJ9uClcL/tkCdyhEMLMOvvj5jPMmWQJSpkAtsL6nNGIB+xZ7KCrHbhQUMybEy6p2YKh PI5g== X-Gm-Message-State: APjAAAWB3d84EctpJpYNKwYWxRxFyY8KB2+89va/zsZeewHYNUIeVjbk OnrwoK3InulcBfsvjaZP+nKZTDgkppzxa8x5SKw/KA== X-Google-Smtp-Source: APXvYqyg8BJ0mWtUnVsZIHd1nlxtEq/TQoby+zEdt5YK0v6BrfynU4C4tehxKhziDkaheD+CcYQOn+z9h45ZgO05JFs= X-Received: by 2002:ac2:51a9:: with SMTP id f9mr9455271lfk.56.1557257083907; Tue, 07 May 2019 12:24:43 -0700 (PDT) MIME-Version: 1.0 References: <20190426050039.17460-1-pagupta@redhat.com> <20190426050039.17460-5-pagupta@redhat.com> In-Reply-To: <20190426050039.17460-5-pagupta@redhat.com> Date: Tue, 7 May 2019 12:24:32 -0700 Message-ID: To: Pankaj Gupta Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::132 X-Mailman-Approved-At: Tue, 07 May 2019 15:52:32 -0400 Subject: Re: [Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?UTF-8?Q?Jakub_Staro=C5=84?= via Qemu-devel Reply-To: =?UTF-8?Q?Jakub_Staro=C5=84?= Cc: cohuck@redhat.com, jack@suse.cz, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger.kernel@dilger.ca, Stephen Barber , zwisler@kernel.org, aarcange@redhat.com, dave.jiang@intel.com, linux-nvdimm@lists.01.org, vishal.l.verma@intel.com, david@redhat.com, willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval.shaia@oracle.com, stefanha@redhat.com, imammedo@redhat.com, dan.j.williams@intel.com, lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong.eric@gmail.com, darrick.wong@oracle.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Pankaj Gupta Date: Thu, Apr 25, 2019 at 10:00 PM > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > + struct dax_device *dax_dev) > +{ > + return !(vma->flags & VM_SYNC); > +} Shouldn't it be rather `return !(vma->vm_flags & VM_SYNC);`? There is no field named `flags` in `struct vm_area_struct`. Thank you, Jakub