Re: [PATCH v3] blockdev-backup: Add error handling option for copy-before-write jobs

[Raman Dzehtsiar <raman.dzehtsiar@gmail.com>]

Hi Markus,

Thanks for taking the time to review this patch.

[...]
> > +# @on-cbw-error: optional policy defining behavior on I/O errors in
> > +#     copy-before-write jobs; defaults to break-guest-write.  (Since 10.0)
[...]
> Scratch "optional", please.

Good point. I've removed "optional" from the description.

[...]
> Also, make it 10.1, and keep the member documentation ordered like ...
>
> >  # @x-perf: Performance options.  (Since 6.0)
> >  #
> >  # Features:
> > @@ -1641,6 +1644,7 @@
> >              '*compress': 'bool',
> >              '*on-source-error': 'BlockdevOnError',
> >              '*on-target-error': 'BlockdevOnError',
> > +            '*on-cbw-error': 'OnCbwError',
> >              '*auto-finalize': 'bool', '*auto-dismiss': 'bool',
> >              '*filter-node-name': 'str',
> >              '*discard-source': 'bool',
>
> ... the actual members.
[...]

The documentation entries have been reordered to match the member
list, and the version tag has been updated to 10.1.

Both issues have been addressed in v4 of the patch.

Thanks again, and kind regards,
Raman Dzehtsiar