From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf9F7-000053-LU for qemu-devel@nongnu.org; Wed, 22 May 2013 09:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf9F1-0006l3-86 for qemu-devel@nongnu.org; Wed, 22 May 2013 09:38:13 -0400 Received: from mail-ob0-x230.google.com ([2607:f8b0:4003:c01::230]:38925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf9F0-0006jY-TO for qemu-devel@nongnu.org; Wed, 22 May 2013 09:38:07 -0400 Received: by mail-ob0-f176.google.com with SMTP id wp18so2263841obc.7 for ; Wed, 22 May 2013 06:38:06 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 22 May 2013 17:38:06 +0400 Message-ID: From: Igor Mitsyanko Content-Type: multipart/alternative; boundary=001a11c30268fdf6a804dd4eac4b Subject: Re: [Qemu-devel] [PATCH arm-devs v1 4/5] sd/sdhci.c: Fix bdata_read DPRINT message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: Peter Maydell , qemu-devel@nongnu.org, edgar.iglesias@gmail.com --001a11c30268fdf6a804dd4eac4b Content-Type: text/plain; charset=ISO-8859-1 On 05/21/2013 10:52 AM, peter.crosthwaite@xilinx.com wrote: From: Peter Crosthwaite This message was printing out the data in decimal only, which is not very friendly to the debugging developer. Add hex variant in parenthesis to make it consistent with other similar messages in this module. Signed-off-by: Peter Crosthwaite --- hw/sd/sdhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index ea510b5..15345dc 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -880,7 +880,8 @@ static uint32_t sdhci_read(SDHCIState *s, unsigned int offset, unsigned size) case SDHC_BDATA: if (sdhci_buff_access_is_sequential(s, offset - SDHC_BDATA)) { ret = SDHCI_GET_CLASS(s)->bdata_read(s, size); - DPRINT_L2("read %ub: addr[0x%04x] -> %u\n", size, offset, ret); + DPRINT_L2("read %ub: addr[0x%04x] -> %u(0x%x)\n", size, offset, + ret, ret); return ret; } break; Reviewed-by: Igor Mitsyanko -- Best wishes, Igor Mitsyanko email: i.mitsyanko@gmail.com --001a11c30268fdf6a804dd4eac4b Content-Type: text/html; charset=ISO-8859-1

On 05/21/2013 10:52 AM, peter.crosthwaite@xilinx.com wrote:
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

This message was printing out the data in decimal only, which is not
very friendly to the debugging developer. Add hex variant in
parenthesis to make it consistent with other similar messages in this
module.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---

 hw/sd/sdhci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index ea510b5..15345dc 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -880,7 +880,8 @@ static uint32_t sdhci_read(SDHCIState *s, unsigned int offset, unsigned size)
     case  SDHC_BDATA:
         if (sdhci_buff_access_is_sequential(s, offset - SDHC_BDATA)) {
             ret = SDHCI_GET_CLASS(s)->bdata_read(s, size);
-            DPRINT_L2("read %ub: addr[0x%04x] -> %u\n", size, offset, ret);
+            DPRINT_L2("read %ub: addr[0x%04x] -> %u(0x%x)\n", size, offset,
+                      ret, ret);
             return ret;
         }
         break;

Reviewed-by: Igor Mitsyanko <i.mitsyanko@gmail.com>

-- 
Best wishes,
Igor Mitsyanko
email: i.mitsyanko@gmail.com
--001a11c30268fdf6a804dd4eac4b--