From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIOgi-0006Dl-HF for qemu-devel@nongnu.org; Wed, 20 Mar 2013 15:28:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIOgf-0003zK-CG for qemu-devel@nongnu.org; Wed, 20 Mar 2013 15:28:40 -0400 Received: from mail-ob0-x234.google.com ([2607:f8b0:4003:c01::234]:38758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIOgf-0003zD-5Q for qemu-devel@nongnu.org; Wed, 20 Mar 2013 15:28:37 -0400 Received: by mail-ob0-f180.google.com with SMTP id ef5so2000987obb.39 for ; Wed, 20 Mar 2013 12:28:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <514A08C4.9040103@gmail.com> References: <1363772625-9182-1-git-send-email-kraxel@redhat.com> <1363772625-9182-13-git-send-email-kraxel@redhat.com> <514A08C4.9040103@gmail.com> Date: Wed, 20 Mar 2013 23:28:36 +0400 Message-ID: From: Igor Mitsyanko Content-Type: multipart/alternative; boundary=14dae93a17fb7dbfe704d8603a45 Subject: Re: [Qemu-devel] [PATCH 12/23] console: simplify screendump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Peter Maydell , Anthony Liguori , Evgeny Voevodin , Stefano Stabellini , qemu-devel@nongnu.org, "open list:X86 , Maksim Kozlov , Dmitry Solodkiy" , Guan Xuetao --14dae93a17fb7dbfe704d8603a45 Content-Type: text/plain; charset=ISO-8859-1 On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> Screendumps are alot simpler as we can update non-active >> QemuConsoles now. So we only need to update the QemuConsole >> we want write out, then dump the DisplaySurface content into >> a ppm file. Done. >> >> No console switching needed. No special support code in the >> gfx card emulation needed. Zap it all. Also move ppm_save >> out of the vga code and next to the qmp_screendump function. >> >> For now screen dumping is limited to console #0 (like it used >> to be), even though it is dead simple to extend it to other >> consoles. I wanna finish the console cleanup before setting >> new qapi interfaces into stone. >> --- >> hw/arm/musicpal.c | 2 +- >> hw/blizzard.c | 14 +----- >> hw/cirrus_vga.c | 4 +- >> hw/exynos4210_fimd.c | 2 +- >> hw/g364fb.c | 73 +--------------------------- >> hw/jazz_led.c | 1 - >> hw/milkymist-vgafb.c | 2 +- >> hw/omap_lcdc.c | 86 +-----------------------------**--- >> hw/pl110.c | 2 +- >> hw/pxa2xx_lcd.c | 2 +- >> hw/qxl.c | 22 +-------- >> hw/sm501.c | 2 +- >> hw/ssd0303.c | 2 +- >> hw/ssd0323.c | 2 +- >> hw/tc6393xb.c | 1 - >> hw/tcx.c | 129 +-----------------------------** >> -------------------- >> hw/unicore32/puv3.c | 2 +- >> hw/vga-isa-mm.c | 2 +- >> hw/vga-isa.c | 2 +- >> hw/vga-pci.c | 2 +- >> hw/vga.c | 66 -------------------------- >> hw/vga_int.h | 2 - >> hw/vmware_vga.c | 26 ---------- >> hw/xenfb.c | 1 - >> include/ui/console.h | 3 -- >> ui/console.c | 69 +++++++++++++++++++-------- >> 26 files changed, 69 insertions(+), 452 deletions(-) >> >> > Tested-by: Igor Mitsyanko --14dae93a17fb7dbfe704d8603a45 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On 03/20= /2013 01:43 PM, Gerd Hoffmann wrote:
Screendumps are alot simpler as we can update non-active
QemuConsoles now. =A0So we only need to update the QemuConsole
we want write out, then dump the DisplaySurface content into
a ppm file. =A0Done.

No console switching needed. =A0No special support code in the
gfx card emulation needed. =A0Zap it all. =A0Also move ppm_save
out of the vga code and next to the qmp_screendump function.

For now screen dumping is limited to console #0 (like it used
to be), even though it is dead simple to extend it to other
consoles. =A0I wanna finish the console cleanup before setting
new qapi interfaces into stone.
---
=A0 hw/arm/musicpal.c =A0 =A0| =A0 =A02 +-
=A0 hw/blizzard.c =A0 =A0 =A0 =A0| =A0 14 +-----
=A0 hw/cirrus_vga.c =A0 =A0 =A0| =A0 =A04 +-
=A0 hw/exynos4210_fimd.c | =A0 =A02 +-
=A0 hw/g364fb.c =A0 =A0 =A0 =A0 =A0| =A0 73 +--------------------------- =A0 hw/jazz_led.c =A0 =A0 =A0 =A0| =A0 =A01 -
=A0 hw/milkymist-vgafb.c | =A0 =A02 +-
=A0 hw/omap_lcdc.c =A0 =A0 =A0 | =A0 86 +--------------------------------
=A0 hw/pl110.c =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0 hw/pxa2xx_lcd.c =A0 =A0 =A0| =A0 =A02 +-
=A0 hw/qxl.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0 22 +--------
=A0 hw/sm501.c =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0 hw/ssd0303.c =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0 hw/ssd0323.c =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0 hw/tc6393xb.c =A0 =A0 =A0 =A0| =A0 =A01 -
=A0 hw/tcx.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0129 +----------------------------= ---------------------
=A0 hw/unicore32/puv3.c =A0| =A0 =A02 +-
=A0 hw/vga-isa-mm.c =A0 =A0 =A0| =A0 =A02 +-
=A0 hw/vga-isa.c =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0 hw/vga-pci.c =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0 hw/vga.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0 66 -------------------------- =A0 hw/vga_int.h =A0 =A0 =A0 =A0 | =A0 =A02 -
=A0 hw/vmware_vga.c =A0 =A0 =A0| =A0 26 ----------
=A0 hw/xenfb.c =A0 =A0 =A0 =A0 =A0 | =A0 =A01 -
=A0 include/ui/console.h | =A0 =A03 --
=A0 ui/console.c =A0 =A0 =A0 =A0 | =A0 69 +++++++++++++++++++--------
=A0 26 files changed, 69 insertions(+), 452 deletions(-)



=A0
=A0Tested-by: Igor Mitsyanko <i.mitsyanko@gmail.= com>

--14dae93a17fb7dbfe704d8603a45--