qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Omer Katz <omer@kazuar-tech.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Filtering files passing through MTP devices
Date: Mon, 23 Apr 2018 15:10:32 +0000	[thread overview]
Message-ID: <CAA-pg_qXZLDEHq6jMN_4GUrFvQgf0AS8Fs559JbucptK6_zrFw@mail.gmail.com> (raw)

Hi everyone,

We have a use case that requires us to only allow certain files to pass
through to the guest machine from USB storage devices.

I was told on IRC that such a feature does not exist but the easiest way to
achieve our goal is to contribute a patch the the MTP device driver since
other drivers operate on a filesystem level instead of a file level which
is what we need.

The plan is to pass the contents of each file to a program through stdin
and decide based on the exit code if the file should be allowed to pass
through to the guest or not.

Since this is the first time I'm contributing to QEMU I'd like some
guidance to where the filtering code should be.
https://github.com/qemu/qemu/blob/master/hw/usb/dev-mtp.c doesn't look that
complicated but I still need to understand it better to continue.
Furthermore, I need to know where to add such a command line option to
point QEMU to the filtering program.

Would such a patch be accepted if all the requirements above are met?

Best Regards,
Omer Katz.

             reply	other threads:[~2018-04-23 15:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 15:10 Omer Katz [this message]
2018-04-25  9:56 ` [Qemu-devel] Filtering files passing through MTP devices Daniel P. Berrangé
2018-04-25 10:39   ` Omer Katz
2018-04-25 16:17     ` Bandan Das
2018-04-25 18:05       ` Omer Katz
2018-04-25 20:20         ` Bandan Das
2018-04-25 20:46           ` Omer Katz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA-pg_qXZLDEHq6jMN_4GUrFvQgf0AS8Fs559JbucptK6_zrFw@mail.gmail.com \
    --to=omer@kazuar-tech.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).