From: Artyom Tarasenko <atar4qemu@gmail.com>
To: Chen Qun <kuhn.chenqun@huawei.com>
Cc: zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, ganqixin@huawei.com,
Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH 5/9] target/sparc/translate: silence the compiler warnings
Date: Wed, 28 Oct 2020 07:39:54 +0100 [thread overview]
Message-ID: <CAAM0arN_5_c-2A2mtO8cSPQbX161a0N0A0obPHPmZa9xburo2A@mail.gmail.com> (raw)
In-Reply-To: <20201028041819.2169003-6-kuhn.chenqun@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
ср, 28 окт. 2020 г., 5:19 Chen Qun <kuhn.chenqun@huawei.com>:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed
> warning:
> target/sparc/translate.c: In function ‘gen_st_asi’:
> target/sparc/translate.c:2320:12: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 2320 | if (!(dc->def->features & CPU_FEATURE_HYPV)) {
> | ^
> target/sparc/translate.c:2329:5: note: here
> 2329 | case GET_ASI_DIRECT:
> | ^~~~
>
> The "fall through" statement place is not correctly identified by the
> compiler.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>
Reviewed-by: Artyom Tarasenko <atar4qemu@gmail.com>
---
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> ---
> target/sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/sparc/translate.c b/target/sparc/translate.c
> index 1a4efd4ed6..a3d9aaa46b 100644
> --- a/target/sparc/translate.c
> +++ b/target/sparc/translate.c
> @@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src,
> TCGv addr,
> }
> /* in OpenSPARC T1+ CPUs TWINX ASIs in store instructions
> * are ST_BLKINIT_ ASIs */
> - /* fall through */
> #endif
> + /* fall through */
> case GET_ASI_DIRECT:
> gen_address_mask(dc, addr);
> tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop);
> --
> 2.27.0
>
>
[-- Attachment #2: Type: text/html, Size: 2795 bytes --]
next prev parent reply other threads:[~2020-10-28 6:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 4:18 [PATCH 0/9] silence the compiler warnings Chen Qun
2020-10-28 4:18 ` [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Chen Qun
2020-10-28 12:57 ` Thomas Huth
2020-10-28 13:20 ` Philippe Mathieu-Daudé
2020-10-28 15:31 ` Richard Henderson
2020-10-28 16:51 ` Thomas Huth
2020-10-29 2:40 ` Chenqun (kuhn)
2020-10-28 15:31 ` Richard Henderson
2020-10-28 4:18 ` [PATCH 2/9] hw/intc/arm_gicv3_kvm: silence the compiler warnings Chen Qun
2020-10-28 20:20 ` Peter Maydell
2020-10-28 4:18 ` [PATCH 3/9] accel/tcg/user-exec: " Chen Qun
2020-10-28 13:52 ` Thomas Huth
2020-10-28 15:37 ` Richard Henderson
2020-10-29 6:13 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 4/9] linux-user/mips/cpu_loop: " Chen Qun
2020-10-28 13:22 ` Thomas Huth
2020-10-28 4:18 ` [PATCH 5/9] target/sparc/translate: " Chen Qun
2020-10-28 6:39 ` Artyom Tarasenko [this message]
2020-10-28 9:50 ` Philippe Mathieu-Daudé
2020-10-28 4:18 ` [PATCH 6/9] target/sparc/win_helper: " Chen Qun
2020-10-28 6:42 ` Artyom Tarasenko
2020-10-28 9:51 ` Philippe Mathieu-Daudé
2020-10-29 2:45 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 7/9] ppc: " Chen Qun
2020-10-28 4:29 ` David Gibson
2020-10-28 14:42 ` Thomas Huth
2020-10-28 23:38 ` David Gibson
2020-10-29 7:06 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 8/9] target/ppc: " Chen Qun
2020-10-28 4:30 ` David Gibson
2020-10-28 9:56 ` Philippe Mathieu-Daudé
2020-10-28 15:06 ` Thomas Huth
2020-10-28 23:39 ` David Gibson
2020-10-29 7:16 ` Chenqun (kuhn)
2020-10-28 4:18 ` [PATCH 9/9] hw/timer/renesas_tmr: " Chen Qun
2020-10-28 9:59 ` Philippe Mathieu-Daudé
2020-10-28 15:04 ` Thomas Huth
2020-10-28 20:14 ` Peter Maydell
2020-10-29 8:26 ` Chenqun (kuhn)
2020-10-29 8:12 ` Chenqun (kuhn)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAM0arN_5_c-2A2mtO8cSPQbX161a0N0A0obPHPmZa9xburo2A@mail.gmail.com \
--to=atar4qemu@gmail.com \
--cc=euler.robot@huawei.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).