From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A61C4363A for ; Wed, 28 Oct 2020 06:42:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E95321775 for ; Wed, 28 Oct 2020 06:42:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OE7WuGnZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E95321775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXf9x-0004gR-Da for qemu-devel@archiver.kernel.org; Wed, 28 Oct 2020 02:42:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXf8N-0003hn-UT; Wed, 28 Oct 2020 02:40:36 -0400 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]:36259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXf8M-00087k-68; Wed, 28 Oct 2020 02:40:35 -0400 Received: by mail-ua1-x943.google.com with SMTP id v27so1235074uau.3; Tue, 27 Oct 2020 23:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/6lGCKv1qN49FzDbD7GV2yvh+sh0KjfqaNQnobByxP0=; b=OE7WuGnZReY8QlbSToovROFac2mGCXxPJNPT0VUDTC8ZSuI1L+C/OLM5g+ZG3H4lCA BL1w956honUD1xsSW8IejHv+OiGBAFCW3A8qVkD+RBjeLClA6zxSuYBiGuezwQiZwXGY TTHtfRlUSav/fgxULTcbfMIIbLr4deLhSfS1i9zIZNb2rQ/gNoV4nM05jvReF1zkIm1e W3/8H6eY5xApyy2nMJBEZk9bBpVKZPsGpex2tAyM8JstX+nGZ3MvwuXDkbS0nusG8MIW McLUWrTWUUQRx6MsdyKr7dZSY3Lp5CcuwgTN34i+6GSWvoIdYg2MFR0bnII8jyD1QUzd GT7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/6lGCKv1qN49FzDbD7GV2yvh+sh0KjfqaNQnobByxP0=; b=cqAP4CLrApLPULbsSF9+uvrYWP2sxrtdw/CIscWfUkzFQRyd5x2aqh+HNAUhH7L02x k8k9pPxXenh3HcR3QzNgBmJ3IM7ukKcCv9btR9+Le7PGs+fRbYXMcWHWMMXZx4mO8LQC DxezTTAq6IbvblnxSRyRUl10XtknlgnekASGt9jOALtUse7i4IYpXzf1hh0HCKRwrU/w /rOqJNI/wy25G2X/aDkj/HiFez6APhJFFxkJnOj3ZFOCj4JCS8XAAeoU4LHYGGVWT0mB S5WniQHpwQPGxadY69dS+zQhk4bTsTJtO2WbZiaQej8wE2DNcZUyhStAzpc39kzx2jpP tqHw== X-Gm-Message-State: AOAM532gJTW8akKX8t2Cf7lYIu0r+9fNi51p8RBLgKS1dQ91jQIJPDJW EgIgWxSkH8xwP5i9b9w4cJpWXWcNpjVnryX1tjg= X-Google-Smtp-Source: ABdhPJwHE3K0T9VE6tD5Cj3/0PhrfzmlE5XkqrD1csE4uFG+JKEqGZa4HrxJu+7WP2AJ7cjGd+ArKiwrkAPmGbb4mqI= X-Received: by 2002:a9f:3f4f:: with SMTP id i15mr3793947uaj.7.1603867229543; Tue, 27 Oct 2020 23:40:29 -0700 (PDT) MIME-Version: 1.0 References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> <20201028041819.2169003-6-kuhn.chenqun@huawei.com> In-Reply-To: <20201028041819.2169003-6-kuhn.chenqun@huawei.com> From: Artyom Tarasenko Date: Wed, 28 Oct 2020 07:39:54 +0100 Message-ID: Subject: Re: [PATCH 5/9] target/sparc/translate: silence the compiler warnings To: Chen Qun Content-Type: multipart/alternative; boundary="0000000000007be18105b2b5706a" Received-SPF: pass client-ip=2607:f8b0:4864:20::943; envelope-from=a.tarasenko@gmail.com; helo=mail-ua1-x943.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org, Mark Cave-Ayland , qemu-devel@nongnu.org, ganqixin@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000007be18105b2b5706a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=81=D1=80, 28 =D0=BE=D0=BA=D1=82. 2020 =D0=B3., 5:19 Chen Qun : > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed > warning: > target/sparc/translate.c: In function =E2=80=98gen_st_asi=E2=80=99: > target/sparc/translate.c:2320:12: warning: this statement may fall throug= h > [-Wimplicit-fallthrough=3D] > 2320 | if (!(dc->def->features & CPU_FEATURE_HYPV)) { > | ^ > target/sparc/translate.c:2329:5: note: here > 2329 | case GET_ASI_DIRECT: > | ^~~~ > > The "fall through" statement place is not correctly identified by the > compiler. > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > Reviewed-by: Artyom Tarasenko --- > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > --- > target/sparc/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/sparc/translate.c b/target/sparc/translate.c > index 1a4efd4ed6..a3d9aaa46b 100644 > --- a/target/sparc/translate.c > +++ b/target/sparc/translate.c > @@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src, > TCGv addr, > } > /* in OpenSPARC T1+ CPUs TWINX ASIs in store instructions > * are ST_BLKINIT_ ASIs */ > - /* fall through */ > #endif > + /* fall through */ > case GET_ASI_DIRECT: > gen_address_mask(dc, addr); > tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop); > -- > 2.27.0 > > --0000000000007be18105b2b5706a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=D1=81=D1=80, 28 =D0=BE=D0=BA=D1=82. 2020 =D0=B3., 5:19 Chen Q= un <kuhn.chenqun@huawei.com>:
When using -Wimplicit-fallt= hrough in our CFLAGS, the compiler showed warning:
target/sparc/translate.c: In function =E2=80=98gen_st_asi=E2=80=99:
target/sparc/translate.c:2320:12: warning: this statement may fall through = [-Wimplicit-fallthrough=3D]
=C2=A02320 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!(dc->def->features= & CPU_FEATURE_HYPV)) {
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
target/sparc/translate.c:2329:5: note: here
=C2=A02329 |=C2=A0 =C2=A0 =C2=A0case GET_ASI_DIRECT:
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0^~~~

The "fall through" statement place is not correctly identified by= the compiler.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>

Reviewed-by= :=C2=A0Artyom Tarasenko <<= a href=3D"mailto:atar4qemu@gmail.com" style=3D"font-family:sans-serif">atar= 4qemu@gmail.com>
=

<= div dir=3D"auto">
---
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
---
=C2=A0target/sparc/translate.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index 1a4efd4ed6..a3d9aaa46b 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TC= Gv addr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* in OpenSPARC T1+ CPUs TWINX ASIs in st= ore instructions
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * are ST_BLKINIT_ ASIs */
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* fall through */
=C2=A0#endif
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* fall through */
=C2=A0 =C2=A0 =C2=A0case GET_ASI_DIRECT:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gen_address_mask(dc, addr);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tcg_gen_qemu_st_tl(src, addr, da.mem_idx,= da.memop);
--
2.27.0

--0000000000007be18105b2b5706a--