qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <ani@anisinha.ca>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: Changes for building bits on newer gcc 9.4 compiler
Date: Fri, 3 Jun 2022 21:38:19 +0530	[thread overview]
Message-ID: <CAARzgwwJ1xeW46+RX779sBf7nWs1okwBBE3qtZXYL4ODsGVPCw@mail.gmail.com> (raw)
In-Reply-To: <CAARzgwyg-n-u+ATuYWsCu35kqos1z7UwcfCAPz-6LTgbQ3q2VA@mail.gmail.com>

On an additional note, my changes are not backward compatible with
older compiler. The build will break when built with a centos 7
docker/vm/host:

/home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c:
In function '_build_callargs':
/home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c:3707:6:
error: empty declaration [-Werror]
      __attribute__ ((fallthrough));
      ^
/home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c:3707:6:
error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
/home/anisinha/workspace/bits/build/grub/grub-core/contrib-deps/python/Modules/_ctypes/_ctypes.c:
At top level:
cc1: error: unrecognized command line option
"-Wno-shift-negative-value" [-Werror]
cc1: error: unrecognized command line option "-Wno-cast-function-type" [-Werror]
cc1: error: unrecognized command line option
"-Wno-address-of-packed-member" [-Werror]
cc1: error: unrecognized command line option
"-Wno-discarded-array-qualifiers" [-Werror]

If fixing this is essential, we can ifdef some of these changes
between compiler version checks.

On Fri, Jun 3, 2022 at 2:06 PM Ani Sinha <ani@anisinha.ca> wrote:
>
> Hi josh :
> Here are the pull requests. Please feel free to review and merge:
>
> Main bits module:
> https://github.com/biosbits/bits/pull/13
>
> Submodules:
> https://github.com/biosbits/grub/pull/1
> https://github.com/biosbits/python/pull/1
> https://github.com/biosbits/libffi/pull/1
> https://github.com/biosbits/fdlibm/pull/1
>
> Thanks
> ani


  reply	other threads:[~2022-06-03 16:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  8:36 Changes for building bits on newer gcc 9.4 compiler Ani Sinha
2022-06-03 16:08 ` Ani Sinha [this message]
2022-06-04  7:56   ` Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAARzgwwJ1xeW46+RX779sBf7nWs1okwBBE3qtZXYL4ODsGVPCw@mail.gmail.com \
    --to=ani@anisinha.ca \
    --cc=imammedo@redhat.com \
    --cc=josh@joshtriplett.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).