Re: [PATCH 13/13] tests/hexagon: add tests for v68 HVX IEEE float comparisons

[Taylor Simpson <ltaylorsimpson@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2715 bytes --]

On Mon, Mar 23, 2026 at 7:16 AM Matheus Tavares Bernardino <
matheus.bernardino@oss.qualcomm.com> wrote:

> Signed-off-by: Matheus Tavares Bernardino <
> matheus.bernardino@oss.qualcomm.com>
> ---
>  tests/tcg/hexagon/hex_test.h      |  1 +
>  tests/tcg/hexagon/fp_hvx_cmp.c    | 58 +++++++++++++++++++++++++++++++
>  tests/tcg/hexagon/Makefile.target |  3 ++
>  3 files changed, 62 insertions(+)
>  create mode 100644 tests/tcg/hexagon/fp_hvx_cmp.c
>
> diff --git a/tests/tcg/hexagon/fp_hvx_cmp.c
> b/tests/tcg/hexagon/fp_hvx_cmp.c
> new file mode 100644
> index 0000000000..e925c973f3
> --- /dev/null
> +++ b/tests/tcg/hexagon/fp_hvx_cmp.c
> @@ -0,0 +1,58 @@
> +/*
> + *  Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + *
> + *  SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#include <stdio.h>
> +#include <stdint.h>
> +#include <stdbool.h>
> +#include <string.h>
> +#include <hexagon_types.h>
> +#include <hvx_hexagon_protos.h>
> +
> +#if __HEXAGON_ARCH__ > 75
> +#error "After v75, compiler will replace some FP HVX instructions."
> +#endif
> +
> +int err;
> +#include "hvx_misc.h"
> +#include "hex_test.h"
> +
> +#define TEST_CMP(VAL1, VAL2, EXP) do { \
> +    ((MMVector *)&buffers[0])->sf[index] = VAL1; \
> +    ((MMVector *)&buffers[1])->sf[index] = VAL2; \
> +    expect[0].w[index] = EXP ? 0xffffffff : 0; \
> +    index++; \
> +} while (0)
> +
> +int main(void)
> +{
> +    HVX_Vector *hvx_output = (HVX_Vector *)&output[0];
> +    HVX_Vector buffers[2], true_vec, false_vec;
> +    HVX_VectorPred pred;
> +    int index = 0;
> +
> +    memset(&buffers, 0, sizeof(buffers));
> +    memset(expect, 0, sizeof(expect));
> +    memset(&true_vec, 0xff, sizeof(true_vec));
> +    memset(&false_vec, 0, sizeof(false_vec));
> +
> +    TEST_CMP(raw_sf(2.2),  raw_sf(2.1),  true);
> +    TEST_CMP(raw_sf(2.2),  raw_sf(2.2),  false);
> +    TEST_CMP(raw_sf(0),    raw_sf(-2.2), true);
> +    TEST_CMP(SF_SNaN,      SF_SNaN,      false);
> +    TEST_CMP(SF_INF,       SF_INF_neg,   true);
> +    TEST_CMP(SF_INF_neg,   SF_INF,       false);
> +    TEST_CMP(SF_SNaN,      SF_QNaN,      false);
> +    TEST_CMP(SF_QNaN,      SF_SNaN,      true);
> +    TEST_CMP(SF_QNaN,      SF_QNaN_neg,  true);
> +
> +    pred = Q6_Q_vcmp_gt_VsfVsf(buffers[0], buffers[1]);
> +    *hvx_output = Q6_V_vmux_QVV(pred, true_vec, false_vec);
> +
> +    check_output_sf(__LINE__, 1);
> +
> +    puts(err ? "FAIL" : "PASS");
> +    return err ? 1 : 0;
> +}
>

We should add some half-float tests as well as and/or/xor versions.
Also, check the FP flags.
Finally, we should add another test for bfloat.

Thanks,
Taylor

[-- Attachment #2: Type: text/html, Size: 3576 bytes --]