From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
haxm-team@intel.com, "Volker Rümelin" <vr_qemu@t-online.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hax: unbreak accelerator cpu code after cpus.c split
Date: Fri, 16 Oct 2020 10:23:31 +0200 [thread overview]
Message-ID: <CAAdtpL48PZTjMHiZe8bHzf06GEYynmXvcuyHM8TUb6ekGGd5kg@mail.gmail.com> (raw)
In-Reply-To: <20201016080032.13914-1-cfontana@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
Le ven. 16 oct. 2020 10:03, Claudio Fontana <cfontana@suse.de> a écrit :
> during my split of cpus.c, code line
> "current_cpu = cpu"
> was removed by mistake, causing hax to break.
>
> This commit fixes the situation restoring it.
>
> Reported-by: Volker Rümelin <vr_qemu@t-online.de>
> Fixes: e92558e4bf8059ce4f0b310afe218802b72766bc
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
> target/i386/hax-cpus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hax-cpus.c b/target/i386/hax-cpus.c
> index 99770e590c..f72c85bd49 100644
> --- a/target/i386/hax-cpus.c
> +++ b/target/i386/hax-cpus.c
> @@ -38,6 +38,7 @@ static void *hax_cpu_thread_fn(void *arg)
> qemu_thread_get_self(cpu->thread);
>
> cpu->thread_id = qemu_get_thread_id();
> + current_cpu = cpu;
> hax_init_vcpu(cpu);
> cpu_thread_signal_created(cpu);
> qemu_guest_random_seed_thread_part2(cpu->random_seed);
> --
> 2.26.2
>
>
>
[-- Attachment #2: Type: text/html, Size: 1852 bytes --]
prev parent reply other threads:[~2020-10-16 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 8:00 [PATCH] hax: unbreak accelerator cpu code after cpus.c split Claudio Fontana
2020-10-16 8:08 ` Paolo Bonzini
2020-10-16 8:23 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdtpL48PZTjMHiZe8bHzf06GEYynmXvcuyHM8TUb6ekGGd5kg@mail.gmail.com \
--to=f4bug@amsat.org \
--cc=cfontana@suse.de \
--cc=haxm-team@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).