From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] meson: fix keymaps witout qemu-keymap
Date: Mon, 31 Aug 2020 17:28:14 +0200 [thread overview]
Message-ID: <CAAdtpL4KFcZsSa-ApRCxt1gDJ+TJPfJkde3RSYQOpYrgAtjHUQ@mail.gmail.com> (raw)
In-Reply-To: <772abf5c-30e2-149f-2507-2c47c016dd7b@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Typo "without" in subject.
Le lun. 31 août 2020 13:15, Thomas Huth <thuth@redhat.com> a écrit :
> On 27/08/2020 12.26, Gerd Hoffmann wrote:
> > In case the qemu-keymap tool generating them is neither installed on the
> > system nor built from sources (due to xkbcommon not being available)
> > qemu will not find the keymaps when started directly from the build
> > tree,
> >
> > This happens because commit ddcf607fa3d6 ("meson: drop keymaps symlink")
> > removed the symlink to the source tree, and the special handling for
> > install doesn't help in case we do not install qemu.
> >
> > Lets fix that by simply copying over the file from the source tree as
> > fallback.
> >
> > Reported-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > pc-bios/keymaps/meson.build | 28 +++++++++++++++++++---------
> > 1 file changed, 19 insertions(+), 9 deletions(-)
>
> Thanks, this fixes the acceptance tests on gitlab-CI for me!
>
> Tested-by: Thomas Huth <thuth@redhat.com>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1692 bytes --]
prev parent reply other threads:[~2020-08-31 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:26 [PATCH] meson: fix keymaps witout qemu-keymap Gerd Hoffmann
2020-08-31 11:15 ` Thomas Huth
2020-08-31 15:28 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdtpL4KFcZsSa-ApRCxt1gDJ+TJPfJkde3RSYQOpYrgAtjHUQ@mail.gmail.com \
--to=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).