* [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/
@ 2017-09-13 22:11 Philippe Mathieu-Daudé
2017-09-14 3:30 ` Stefan Weil
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-13 22:11 UTC (permalink / raw)
To: Richard Henderson, Paolo Bonzini, Jiang Yunhong, Vincent Palatin
Cc: Philippe Mathieu-Daudé, qemu-devel
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Makefile.target | 1 -
hax-stub.c => accel/stubs/hax-stub.c | 0
accel/stubs/Makefile.objs | 1 +
3 files changed, 1 insertion(+), 1 deletion(-)
rename hax-stub.c => accel/stubs/hax-stub.c (100%)
diff --git a/Makefile.target b/Makefile.target
index 6361f957fb..af4b60d012 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -101,7 +101,6 @@ obj-y += fpu/softfloat.o
obj-y += target/$(TARGET_BASE_ARCH)/
obj-y += disas.o
obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
-obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decContext.o
obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decNumber.o
diff --git a/hax-stub.c b/accel/stubs/hax-stub.c
similarity index 100%
rename from hax-stub.c
rename to accel/stubs/hax-stub.c
diff --git a/accel/stubs/Makefile.objs b/accel/stubs/Makefile.objs
index fdfbf7332c..8038ad6553 100644
--- a/accel/stubs/Makefile.objs
+++ b/accel/stubs/Makefile.objs
@@ -1,2 +1,3 @@
obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
+obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/
2017-09-13 22:11 [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/ Philippe Mathieu-Daudé
@ 2017-09-14 3:30 ` Stefan Weil
2017-09-14 4:46 ` Philippe Mathieu-Daudé
2017-09-14 11:40 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2017-09-14 3:30 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Richard Henderson, Paolo Bonzini,
Jiang Yunhong, Vincent Palatin
Cc: qemu-devel
Am 14.09.2017 um 00:11 schrieb Philippe Mathieu-Daudé:
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Makefile.target | 1 -
> hax-stub.c => accel/stubs/hax-stub.c | 0
> accel/stubs/Makefile.objs | 1 +
> 3 files changed, 1 insertion(+), 1 deletion(-)
> rename hax-stub.c => accel/stubs/hax-stub.c (100%)
>
> diff --git a/Makefile.target b/Makefile.target
> index 6361f957fb..af4b60d012 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -101,7 +101,6 @@ obj-y += fpu/softfloat.o
> obj-y += target/$(TARGET_BASE_ARCH)/
> obj-y += disas.o
> obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
> -obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>
> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decContext.o
> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decNumber.o
> diff --git a/hax-stub.c b/accel/stubs/hax-stub.c
> similarity index 100%
> rename from hax-stub.c
> rename to accel/stubs/hax-stub.c
> diff --git a/accel/stubs/Makefile.objs b/accel/stubs/Makefile.objs
> index fdfbf7332c..8038ad6553 100644
> --- a/accel/stubs/Makefile.objs
> +++ b/accel/stubs/Makefile.objs
> @@ -1,2 +1,3 @@
> obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
> obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Personally, I like alphabetic order for such lines.
Maybe that can be done when it is applied.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/
2017-09-14 3:30 ` Stefan Weil
@ 2017-09-14 4:46 ` Philippe Mathieu-Daudé
2017-09-14 11:40 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-14 4:46 UTC (permalink / raw)
To: Stefan Weil, Richard Henderson
Cc: Paolo Bonzini, Vincent Palatin, qemu-devel@nongnu.org Developers
>> --- a/accel/stubs/Makefile.objs
>> +++ b/accel/stubs/Makefile.objs
>> @@ -1,2 +1,3 @@
>> obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
>> obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
>> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
Thanks!
>
> Personally, I like alphabetic order for such lines.
> Maybe that can be done when it is applied.
Fine by me ;)
Richard if you plan to take this, tell me if you prefer another patch
alphabetically sorted.
Regards,
Phil.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/
2017-09-14 3:30 ` Stefan Weil
2017-09-14 4:46 ` Philippe Mathieu-Daudé
@ 2017-09-14 11:40 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2017-09-14 11:40 UTC (permalink / raw)
To: Stefan Weil, Philippe Mathieu-Daudé, Richard Henderson,
Jiang Yunhong, Vincent Palatin
Cc: qemu-devel
On 14/09/2017 05:30, Stefan Weil wrote:
> Am 14.09.2017 um 00:11 schrieb Philippe Mathieu-Daudé:
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Makefile.target | 1 -
>> hax-stub.c => accel/stubs/hax-stub.c | 0
>> accel/stubs/Makefile.objs | 1 +
>> 3 files changed, 1 insertion(+), 1 deletion(-)
>> rename hax-stub.c => accel/stubs/hax-stub.c (100%)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 6361f957fb..af4b60d012 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -101,7 +101,6 @@ obj-y += fpu/softfloat.o
>> obj-y += target/$(TARGET_BASE_ARCH)/
>> obj-y += disas.o
>> obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
>> -obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>>
>> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decContext.o
>> obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decNumber.o
>> diff --git a/hax-stub.c b/accel/stubs/hax-stub.c
>> similarity index 100%
>> rename from hax-stub.c
>> rename to accel/stubs/hax-stub.c
>> diff --git a/accel/stubs/Makefile.objs b/accel/stubs/Makefile.objs
>> index fdfbf7332c..8038ad6553 100644
>> --- a/accel/stubs/Makefile.objs
>> +++ b/accel/stubs/Makefile.objs
>> @@ -1,2 +1,3 @@
>> obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
>> obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
>> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Personally, I like alphabetic order for such lines.
> Maybe that can be done when it is applied.
Done and queued, thanks both.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-14 11:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-13 22:11 [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/ Philippe Mathieu-Daudé
2017-09-14 3:30 ` Stefan Weil
2017-09-14 4:46 ` Philippe Mathieu-Daudé
2017-09-14 11:40 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).