From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v2] kvm: fix memory leak on failure to read stats descriptors
Date: Mon, 5 Sep 2022 23:32:02 +0200 [thread overview]
Message-ID: <CAAdtpL5SoakRBooFcF3SSVz-CQ4g6098d7PwSUxRrxYYD+6+ng@mail.gmail.com> (raw)
In-Reply-To: <20220905123910.46703-1-pbonzini@redhat.com>
On Mon, Sep 5, 2022 at 3:28 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Reported by Coverity as CID 1490142. Since the size is constant and the
> lifetime is the same as the StatsDescriptors struct, embed the struct
> directly instead of using a separate allocation.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> accel/kvm/kvm-all.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
prev parent reply other threads:[~2022-09-05 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 12:39 [PATCH v2] kvm: fix memory leak on failure to read stats descriptors Paolo Bonzini
2022-09-05 15:57 ` Richard Henderson
2022-09-05 21:32 ` Philippe Mathieu-Daudé via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdtpL5SoakRBooFcF3SSVz-CQ4g6098d7PwSUxRrxYYD+6+ng@mail.gmail.com \
--to=qemu-devel@nongnu.org \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).