From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups
Date: Mon, 30 Oct 2017 16:09:53 -0300 [thread overview]
Message-ID: <CAAdtpL61YQxwqhS-4pDRVM=Y3B2sJgpipjgUwA28ocvxP+FNfA@mail.gmail.com> (raw)
In-Reply-To: <836e7a63-c841-a866-c82c-04bf785420ca@ilande.co.uk>
On Mon, Oct 30, 2017 at 4:00 PM, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> On 27/10/17 17:42, Philippe Mathieu-Daudé wrote:
[...]
>> If you don't accept my comments (or don't have time) about keeping
>> "hw/sparc/sparc32_dma.h" generic and moving network/scsi parts in
>> "hw/sparc/sun4m.h" you can still add to your series:
>>
>> Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Thanks for the review, I've added your R-B tags to the individual
> patches. Note that while potentially I could move the network/scsi parts
> to hw/sparc/sun4m.h I feel that it's a slightly better match for the
> SPARC32 DMA container device to remain in sparc32_dma.c. So for these
> patches I've just added your A-B tag.
OK.
>> Also while testing your series on a Debian image, I noted your series
>> results faster, I timed:
>>
>> master: 104s
>> your series: 85s (>20% faster!)
>
> Really? Is that for just this patchset or also with the v2 IOMMU
> patchset applied on top? I can't immediately see how moving the logic
> into sparc32_dma.c could make a difference here...
Yes, I was trying with both series applied, so this comment belong to
the other series (IOMMU).
Regards,
Phil.
prev parent reply other threads:[~2017-10-30 19:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 15:59 [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups Mark Cave-Ayland
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 01/13] sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE Mark Cave-Ayland
2017-10-27 16:27 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 02/13] sparc32_dma: split esp and le into separate DMA devices Mark Cave-Ayland
2017-10-27 15:40 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 03/13] sparc32_dma: move type declarations from sparc32_dma.c to sparc32_dma.h Mark Cave-Ayland
2017-10-27 16:04 ` Philippe Mathieu-Daudé
2017-10-27 19:02 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 04/13] sun4m: move DMA device wiring from sparc32_dma_init() to sun4m_hw_init() Mark Cave-Ayland
2017-10-27 15:46 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 05/13] sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to sun4m.h Mark Cave-Ayland
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 06/13] sparc32_dma: use object link instead of qdev property to pass IOMMU reference Mark Cave-Ayland
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 07/13] esp: move TYPE_ESP and SysBusESPState from esp.c to esp.h Mark Cave-Ayland
2017-10-27 15:51 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 08/13] sparc32_dma: make esp device child of espdma device Mark Cave-Ayland
2017-10-27 16:08 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h Mark Cave-Ayland
2017-10-25 17:47 ` Peter Maydell
2017-10-26 10:12 ` Mark Cave-Ayland
2017-10-30 13:10 ` Mark Cave-Ayland
2017-10-30 13:22 ` Peter Maydell
2017-10-30 18:19 ` Mark Cave-Ayland
2017-10-30 18:45 ` Philippe Mathieu-Daudé
2017-10-30 19:08 ` Mark Cave-Ayland
2017-10-27 15:53 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 10/13] sparc32_dma: make lance device child of ledma device Mark Cave-Ayland
2017-10-27 16:11 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 11/13] sparc32_dma: introduce new SPARC32_DMA type container object Mark Cave-Ayland
2017-10-27 16:18 ` Philippe Mathieu-Daudé
2017-10-30 18:51 ` Mark Cave-Ayland
2017-10-30 18:55 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 12/13] sparc32_dma: remove is_ledma hack and replace with memory region alias Mark Cave-Ayland
2017-10-27 16:20 ` Philippe Mathieu-Daudé
2017-10-25 15:59 ` [Qemu-devel] [PATCHv4 13/13] sparc32_dma: add len to esp/le DMA memory tracing Mark Cave-Ayland
2017-10-25 16:04 ` [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups Artyom Tarasenko
2017-10-25 16:16 ` no-reply
2017-10-27 16:42 ` Philippe Mathieu-Daudé
2017-10-30 19:00 ` Mark Cave-Ayland
2017-10-30 19:09 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdtpL61YQxwqhS-4pDRVM=Y3B2sJgpipjgUwA28ocvxP+FNfA@mail.gmail.com' \
--to=f4bug@amsat.org \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).