[Qemu-devel] [PATCH] util/cacheinfo: add missing include

[Qemu-devel] [PATCH] util/cacheinfo: add missing include

[Philippe Mathieu-Daudé]

This include was forgotten when splitting cacheinfo.c out of
tcg/ppc/tcg-target.inc.c (see commit b255b2c8).

While compiling on powerpc:

      CC      util/cacheinfo.o
    qemu/util/cacheinfo.c: In function 'arch_cache_info':
    qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared (first use in this function)
             *isize = qemu_getauxval(AT_ICACHEBSIZE);
                                     ^
    qemu/util/cacheinfo.c:137:33: note: each undeclared identifier is reported only once for each function it appears in
    qemu/util/cacheinfo.c:140:33: error: 'AT_DCACHEBSIZE' undeclared (first use in this function)
             *dsize = qemu_getauxval(AT_DCACHEBSIZE);
                                     ^
    qemu/rules.mak:66: recipe for target 'util/cacheinfo.o' failed
    make: *** [util/cacheinfo.o] Error 1

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 util/cacheinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/cacheinfo.c b/util/cacheinfo.c
index 6253049533..593940f27b 100644
--- a/util/cacheinfo.c
+++ b/util/cacheinfo.c
@@ -129,6 +129,7 @@ static void arch_cache_info(int *isize, int *dsize)
 }
 
 #elif defined(_ARCH_PPC) && defined(__linux__)
+# include "elf.h"
 
 static void arch_cache_info(int *isize, int *dsize)
 {
-- 
2.13.2

Re: [Qemu-devel] [PATCH] util/cacheinfo: add missing include

[Richard Henderson]

On 07/10/2017 03:55 PM, Philippe Mathieu-Daudé wrote:
> This include was forgotten when splitting cacheinfo.c out of
> tcg/ppc/tcg-target.inc.c (see commit b255b2c8).
> 
> While compiling on powerpc:
> 
>        CC      util/cacheinfo.o
>      qemu/util/cacheinfo.c: In function 'arch_cache_info':
>      qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared (first use in this function)
>               *isize = qemu_getauxval(AT_ICACHEBSIZE);
>                                       ^
>      qemu/util/cacheinfo.c:137:33: note: each undeclared identifier is reported only once for each function it appears in
>      qemu/util/cacheinfo.c:140:33: error: 'AT_DCACHEBSIZE' undeclared (first use in this function)
>               *dsize = qemu_getauxval(AT_DCACHEBSIZE);
>                                       ^
>      qemu/rules.mak:66: recipe for target 'util/cacheinfo.o' failed
>      make: *** [util/cacheinfo.o] Error 1

For the record, what is the os version?
Because this doesn't happen here for Centos7.


r~

Re: [Qemu-devel] [PATCH] util/cacheinfo: add missing include

[Philippe Mathieu-Daudé]

Hi Richard,

On Mon, Jul 10, 2017 at 11:38 PM, Richard Henderson <rth@twiddle.net> wrote:
> On 07/10/2017 03:55 PM, Philippe Mathieu-Daudé wrote:
>>
>> This include was forgotten when splitting cacheinfo.c out of
>> tcg/ppc/tcg-target.inc.c (see commit b255b2c8).
>>
>> While compiling on powerpc:
>>
>>        CC      util/cacheinfo.o
>>      qemu/util/cacheinfo.c: In function 'arch_cache_info':
>>      qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared
>> (first use in this function)
>>               *isize = qemu_getauxval(AT_ICACHEBSIZE);
>>                                       ^
>>      qemu/util/cacheinfo.c:137:33: note: each undeclared identifier is
>> reported only once for each function it appears in
>>      qemu/util/cacheinfo.c:140:33: error: 'AT_DCACHEBSIZE' undeclared
>> (first use in this function)
>>               *dsize = qemu_getauxval(AT_DCACHEBSIZE);
>>                                       ^
>>      qemu/rules.mak:66: recipe for target 'util/cacheinfo.o' failed
>>      make: *** [util/cacheinfo.o] Error 1
>
>
> For the record, what is the os version?
> Because this doesn't happen here for Centos7.

Oops true I forgot to log this info in the commit.

This happens on debian/powerpc Jessie, using GCC 4.9.2-10

$ make subdir-ppc-softmmu
  CC      util/cacheinfo.o
/home/phil/source/qemu/util/cacheinfo.c: In function 'arch_cache_info':
/home/phil/source/qemu/util/cacheinfo.c:137:33: error:
'AT_ICACHEBSIZE' undeclared (first use in this function)
         *isize = qemu_getauxval(AT_ICACHEBSIZE);
                                 ^

compiling with -dU:

#define _ARCH_PPC 1
# 134 "/home/phil/source/qemu/util/cacheinfo.c"
static void arch_cache_info(int *isize, int *dsize)
{
    if (*isize == 0) {
        *isize = qemu_getauxval(AT_ICACHEBSIZE);
    }
    if (*dsize == 0) {
        *dsize = qemu_getauxval(AT_DCACHEBSIZE);
    }
}

Regards,

Phil.

Re: [Qemu-devel] [PATCH] util/cacheinfo: add missing include

[Richard Henderson]

On 07/10/2017 05:27 PM, Philippe Mathieu-Daudé wrote:
>> For the record, what is the os version?
>> Because this doesn't happen here for Centos7.
> Oops true I forgot to log this info in the commit.
> 
> This happens on debian/powerpc Jessie, using GCC 4.9.2-10

Thanks.  Queued to tcg-next.


r~