From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA847C33CA2 for ; Fri, 10 Jan 2020 08:26:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDA902072E for ; Fri, 10 Jan 2020 08:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDA902072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ippdB-0005Mv-VJ for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 03:26:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54619) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ippcX-0004aB-7X for qemu-devel@nongnu.org; Fri, 10 Jan 2020 03:26:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ippcT-0004rV-3O for qemu-devel@nongnu.org; Fri, 10 Jan 2020 03:26:17 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:38501) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ippcS-0004ny-V2 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 03:26:13 -0500 Received: by mail-yw1-f67.google.com with SMTP id 10so374466ywv.5 for ; Fri, 10 Jan 2020 00:26:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vnW91p0D4LbnQOTBltGPp9J5/nmmhN5FkHVlD//TexM=; b=OSqdpfzmPGEFWmsqcJ24tjUT1LiTfT5+MDAS6irD7pbkhyJ/0pUoOOsV9GpishIE0z lUgc+gHa349OZMu3RoBURpHx0mC259cwmk1zI13ng5u4VEpA4LLhR+gBAouO89sN6ob3 gdQ5A4NU0qTm9eFtNE5E+Z9jF2bleXN6fxY4kdp6q2vFOI3LjgWiKuCF09FC7O/eZuqZ tUQzMklBWQZnax9nikdQnxaDTyfBZ1/nRnqyRuvKHQIASBEyvhaRcaHoBQ+PpkxfNka7 q0mVXeBODk/LbTV+3W2hXS6sGFU5sjWlgQ63sNkqTSYL/sCZ1aqSQvSW3IuXqFGaPNJf 2wmg== X-Gm-Message-State: APjAAAV+whYNfj4Dgawl8XT67caAkAwwk8T9LAkD4jM5DS31rL6hSyZX WudnsC2X3Mzk33XlgnPSOsGOZosk0QfekzciY3o= X-Google-Smtp-Source: APXvYqwhzkxsAX6fH6tuzi2iR/AT+uBRjN2zd8su3JUGUV8oXjLZLLBRtiB4rSbIOrnfxtcfpDzbNb+RStSrQU78kUQ= X-Received: by 2002:a81:3b15:: with SMTP id i21mr1782076ywa.368.1578644771856; Fri, 10 Jan 2020 00:26:11 -0800 (PST) MIME-Version: 1.0 References: <20200109153939.27173-1-philmd@redhat.com> <20200109153939.27173-4-philmd@redhat.com> In-Reply-To: From: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Date: Fri, 10 Jan 2020 09:25:22 +0100 Message-ID: Subject: Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects To: Thomas Huth Content-Type: multipart/alternative; boundary="000000000000da6892059bc4e004" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.161.67 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , "qemu-devel@nongnu.org Developers" , Laurent Vivier , Paolo Bonzini , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000da6892059bc4e004 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le ven. 10 janv. 2020 09:18, Thomas Huth a =C3=A9crit : > On 09/01/2020 16.39, Philippe Mathieu-Daud=C3=A9 wrote: > > Restrict all the system emulation and tools objects with a > > Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. > > > > Using the same description over and over is not very helpful. > > Use it once, just before the if() block. > > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > --- > > Makefile.objs | 19 +++++++------------ > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > diff --git a/Makefile.objs b/Makefile.objs > > index 5aae561984..395dd1e670 100644 > > --- a/Makefile.objs > > +++ b/Makefile.objs > > @@ -4,16 +4,15 @@ stub-obj-y =3D stubs/ > > util-obj-y =3D crypto/ util/ qobject/ qapi/ > > qom-obj-y =3D qom/ > > > > +######################################################################= # > > +# code used by both qemu system emulation and qemu-img > > + > > +ifeq ($(call lor,$(CONFIG_SOFTMMU),$(CONFIG_TOOLS)),y) > > That ",y" at the end looks wrong? > It's the result of the logical OR. --000000000000da6892059bc4e004 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Le ven. 10 janv. 2020 09:18, Thomas Huth <thuth@redhat.com> a =C3=A9crit=C2=A0:
On 09/01/2020 16.39, Philippe Mathieu-Daud=C3= =A9 wrote:
> Restrict all the system emulation and tools objects with a
> Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check.
>
> Using the same description over and over is not very helpful.
> Use it once, just before the if() block.
>
> Signed-off-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>= ;
> ---
>=C2=A0 Makefile.objs | 19 +++++++------------
>=C2=A0 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 5aae561984..395dd1e670 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -4,16 +4,15 @@ stub-obj-y =3D stubs/
>=C2=A0 util-obj-y =3D crypto/ util/ qobject/ qapi/
>=C2=A0 qom-obj-y =3D qom/
>=C2=A0
> +#####################################################################= ##
> +# code used by both qemu system emulation and qemu-img
> +
> +ifeq ($(call lor,$(CONFIG_SOFTMMU),$(CONFIG_TOOLS)),y)

That ",y" at the end looks wrong?

It's the result of the logic= al OR.
--000000000000da6892059bc4e004--