From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D00B5C4361B for ; Tue, 8 Dec 2020 18:58:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52A7A23B55 for ; Tue, 8 Dec 2020 18:58:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52A7A23B55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmiBi-0006RZ-6Q for qemu-devel@archiver.kernel.org; Tue, 08 Dec 2020 13:58:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmhpS-0003Eu-L0 for qemu-devel@nongnu.org; Tue, 08 Dec 2020 13:35:14 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:35267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmhpQ-0001WW-DZ for qemu-devel@nongnu.org; Tue, 08 Dec 2020 13:35:14 -0500 Received: by mail-oi1-f180.google.com with SMTP id s2so10964714oij.2 for ; Tue, 08 Dec 2020 10:35:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ECYhv0HdEqAA4hvDfOlc1eUdDVUikLV2SPOarY0ohHc=; b=tz+ul+MgWQHkBFnb6RwvxHPcc8qIfZKdtJ9hc46P0jefQO+Ol3yzRMmoJOznjpxwDp HD48SLrGBXxHSzrnGs9obEfRmjqXTCIHmM8ZsvRQD80DevzkgbdKjvlsaq1oSVAFpVBU R7lEZD4nJzDM3VBV3E+vewecfrqEWvrVXq4uDxyhS4gnfNkKTxpMd5fce1KFM/P8301O afoMBZPcuAwdms4nd0hkgVcP4V/wLunaWq3IOhYeHHUonU7J1XI7QmqSP3FP7Pl/OgeJ OcDcyd8MIcf7EsRc7PLplEslII1zbBhYyd7mYQvXgNKQoYuV59jSbeSyTF9DgNExfe4e PuRQ== X-Gm-Message-State: AOAM530VSRDE6hQvusE9xoG0Uw+6hrcxj9tN3ireIkanBkfBarVhT9xa TQJEa1cmWPS+eXhgMjKJ4qG2QhDEeJtmEjXDZ5E= X-Google-Smtp-Source: ABdhPJywG/e9nv3r9kjEPP6LFWk7bybRWZz3kIweUvpqnToJFbITBvVVTF0rFPW1ALLhCcPlrx8tnaZnscNtlgGiz6U= X-Received: by 2002:aca:5cc1:: with SMTP id q184mr3845094oib.46.1607452511251; Tue, 08 Dec 2020 10:35:11 -0800 (PST) MIME-Version: 1.0 References: <20201124134557.569388-1-f4bug@amsat.org> <5bcade19-de8c-8521-f77c-599e3c9d40a0@linaro.org> In-Reply-To: From: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Date: Tue, 8 Dec 2020 19:34:59 +0100 Message-ID: Subject: Re: [PATCH-for-5.2?] target/mips/translate: Check R6 reserved encoding for Load Linked Word To: Richard Henderson , "qemu-devel@nongnu.org Developers" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.167.180; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-oi1-f180.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , "Maciej W . Rozycki" , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Nov 24, 2020 at 5:15 PM Philippe Mathieu-Daud=C3=A9 wrote: > On 11/24/20 4:59 PM, Richard Henderson wrote: > > On 11/24/20 5:45 AM, Philippe Mathieu-Daud=C3=A9 wrote: > >> Release 6 recoded the 'Load Linked Word' using SPECIAL3 opcode, > >> this opcode (0b110000) is now reserved. > >> > >> Ref: A.2 Instruction Bit Encoding Tables: > >> > >> "6Rm instructions signal a Reserved Instruction exception > >> when executed by a Release 6 implementation." > >> > >> The check was added in commit 4368b29a26e ("target-mips: move > >> LL and SC instructions") but got lost during latter refactor > >> in commit d9224450208 ("target-mips: Tighten ISA level checks"). > > > > I think git blame is confused here -- d9224450208 isn't the one that br= oke > > things. The patch has: > > > > > > + case OPC_LL: /* Load and stores */ > > + check_insn(ctx, ISA_MIPS2); > > + /* Fallthrough */ > > + case OPC_LWL: > > case OPC_LWR: > > - case OPC_LL: > > check_insn_opc_removed(ctx, ISA_MIPS32R6); > > + /* Fallthrough */ > > Sorry I have been confused by the /* Fallthrough */ ... > > The check is below. > > Self-NAck then. Duh I hit that again, read the patch again, looks correct. I guess I got confused myself reviewing the offending patch... So I'm applying this patch to mips-next queue, using Fixes: d9224450208 ("target-mips: Tighten ISA level checks") Thanks, Phil.