From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Alistair Francis <alistair23@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH 2/2] target/riscv: fence: reconcile with specification
Date: Thu, 8 Sep 2022 11:28:40 +0200 [thread overview]
Message-ID: <CAAeLtUBKmLQpq3swsBJyNG14f35WO1hqr=oT4xfEovUWa0T4yA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKMCUyTtTarDcXjxjTDe7JapuegxMB9x57rtG+7rNELVQg@mail.gmail.com>
On Thu, 8 Sept 2022 at 11:25, Alistair Francis <alistair23@gmail.com> wrote:
>
> On Fri, Aug 12, 2022 at 4:19 PM Philipp Tomsich
> <philipp.tomsich@vrull.eu> wrote:
> >
> > Happy to lower it back into the decode file.
> > However, I initially pulled it up into the trans-function to more
> > closely match the ISA specification: there is only one FENCE
> > instruction with 3 arguments (FM, PRED, and SUCC).
> > One might argue that the decode table for "RV32I Base Instruction Set"
> > in the specification lists FENCE.TSO as a separate instruction, but
> > the normative text doesn't (and FENCE overlaps FENCE.TSO in the
> > tabular representation) — so I would consider the table as
> > informative.
> >
> > I'll wait until we see what consensus emerges from the discussion.
>
> From the discussion on patch 1 it seems that QEMU ignoring these
> fields (current behaviour) is correct
Yes, this is an accurate reading of the situation.
Philipp.
next prev parent reply other threads:[~2022-09-08 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 13:13 [PATCH 1/2] target/riscv: fence.i: update decode pattern Philipp Tomsich
2022-08-12 13:13 ` [PATCH 2/2] target/riscv: fence: reconcile with specification Philipp Tomsich
2022-08-12 13:21 ` Peter Maydell
2022-08-12 14:17 ` Philipp Tomsich
2022-09-08 9:24 ` Alistair Francis
2022-09-08 9:28 ` Philipp Tomsich [this message]
2022-08-12 14:03 ` Andrew Jones
2022-08-12 14:01 ` [PATCH 1/2] target/riscv: fence.i: update decode pattern Andrew Jones
2022-08-12 14:09 ` Philipp Tomsich
2022-08-12 14:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeLtUBKmLQpq3swsBJyNG14f35WO1hqr=oT4xfEovUWa0T4yA@mail.gmail.com' \
--to=philipp.tomsich@vrull.eu \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bin.meng@windriver.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).