From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF729CCF9E9 for ; Wed, 6 Sep 2023 01:21:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdhDv-0005sa-Ud; Tue, 05 Sep 2023 21:20:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdhDr-0005r1-0G for qemu-devel@nongnu.org; Tue, 05 Sep 2023 21:20:48 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdhDn-0003vh-TU for qemu-devel@nongnu.org; Tue, 05 Sep 2023 21:20:46 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bd0d135ca3so53088321fa.3 for ; Tue, 05 Sep 2023 18:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693963241; x=1694568041; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YKzdHmJquKXWVSJeYgYm2iRBv8SFP5FpoylDUQCDYBk=; b=F1ITU5tDyzSrypHm7OzXhRspBgK9m+p9QBmQBtYY7NIayPxJkWxkFEx3jm26IdZ2Kj td/EYSWHBxGSMYbUhtsJ56UYxWe6pRErP6HGC+mtiblgIvLOg06vjMXuILAgFj9EIrH1 J+0+IbQQhBpHhGU14NrkPs81XNED2f7M7+GB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693963241; x=1694568041; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YKzdHmJquKXWVSJeYgYm2iRBv8SFP5FpoylDUQCDYBk=; b=NwRTccL8Sqehf9F9/tlfJD/bFGt26GcAgTocVQBMUj57sKvjaX64OZ7z+pf542oBDV ZSTOmlcmuCrNxj5voh7aTP9MUrJVNnKMh7mMl4AgSxJKJOV6I2BAaIA7sKqc/VUGK+fL YAhexnmSfOJLOjaPAhGKjKjxiHPt9lU1jb7FjdBTlBhkHASpsBMfosXoZ5bUYCCEBXf5 JpamjD94HQrsrit7duRsYHiBU8fJ1VLNMQ2RQBlSHJKhelUmiQbQGVrKY1d6hMhPc2V1 vDoq5kT4sUo1AKvL3OnEvOD9hT3+C6QSDumop+aDiCesMtbW5/VOmlNMUraHflU8T9gK H7cw== X-Gm-Message-State: AOJu0Yw+1mr4/J4eMrSQNmbgnN8ErDUpu0b1lou13BZTcoRKol59oxOo 6M/Im/UJSzFBBRiObTDUaxquv5/TLrsrhYgtBqobJA== X-Google-Smtp-Source: AGHT+IF4Up3fa4B50rvTE8qbxhJBv4AnZ1o5m25mV0+Q5Ll6d/hqW7RIy5RydQebkK5Vqc335eJ4bA== X-Received: by 2002:a2e:3603:0:b0:2b9:e53f:e201 with SMTP id d3-20020a2e3603000000b002b9e53fe201mr1020490lja.31.1693963240826; Tue, 05 Sep 2023 18:20:40 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id w20-20020a2e3014000000b002bcb89e92dcsm3174291ljw.6.2023.09.05.18.20.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 18:20:40 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50095f6bdc5so1079e87.1 for ; Tue, 05 Sep 2023 18:20:40 -0700 (PDT) X-Received: by 2002:ac2:47e9:0:b0:501:a31d:59ef with SMTP id b9-20020ac247e9000000b00501a31d59efmr32972lfp.3.1693963240098; Tue, 05 Sep 2023 18:20:40 -0700 (PDT) MIME-Version: 1.0 References: <20230829003629.410-1-gurchetansingh@chromium.org> In-Reply-To: From: Gurchetan Singh Date: Tue, 5 Sep 2023 18:20:27 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 0/9] rutabaga_gfx + gfxstream To: Huang Rui Cc: "qemu-devel@nongnu.org" , "marcandre.lureau@redhat.com" , "akihiko.odaki@gmail.com" , "alex.bennee@linaro.org" , "shentey@gmail.com" , "hi@alyssa.is" , "ernunes@redhat.com" , "manos.pitsidianakis@linaro.org" , "philmd@linaro.org" , "mark.cave-ayland@ilande.co.uk" , Gerd Hoffmann Content-Type: multipart/alternative; boundary="000000000000310d5a0604a68dea" Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=gurchetansingh@chromium.org; helo=mail-lj1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --000000000000310d5a0604a68dea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 30, 2023 at 7:26=E2=80=AFPM Huang Rui wrote= : > On Tue, Aug 29, 2023 at 08:36:20AM +0800, Gurchetan Singh wrote: > > From: Gurchetan Singh > > > > Changes since v12: > > - Added r-b tags from Antonio Caggiano and Akihiko Odaki > > - Removed review version from commit messages > > - I think we're good to merge since we've had multiple people test and > review this series?? > > > > How to build both rutabaga and gfxstream guest/host libs: > > > > https://crosvm.dev/book/appendix/rutabaga_gfx.html > > > > Branch containing this patch series: > > > > https://gitlab.com/gurchetansingh/qemu/-/commits/qemu-gfxstream-v13 > > > > Antonio Caggiano (2): > > virtio-gpu: CONTEXT_INIT feature > > virtio-gpu: blob prep > > > > Dr. David Alan Gilbert (1): > > virtio: Add shared memory capability > > > > Gerd Hoffmann (1): > > virtio-gpu: hostmem > > Patch 1 -> 4 are > > Acked-and-Tested-by: Huang Rui > Thanks Ray, I've rebased https://gitlab.com/gurchetansingh/qemu/-/commits/qemu-gfxstream-v13 and added the additional acks in the commit message. UI/gfx maintainers, since everything is reviewed and there hasn't been any additional review comments, may we merge the gfxstream + rutabaga_gfx series? Thank you! > > > > > Gurchetan Singh (5): > > gfxstream + rutabaga prep: added need defintions, fields, and options > > gfxstream + rutabaga: add initial support for gfxstream > > gfxstream + rutabaga: meson support > > gfxstream + rutabaga: enable rutabaga > > docs/system: add basic virtio-gpu documentation > > > > docs/system/device-emulation.rst | 1 + > > docs/system/devices/virtio-gpu.rst | 112 +++ > > hw/display/meson.build | 22 + > > hw/display/virtio-gpu-base.c | 6 +- > > hw/display/virtio-gpu-pci-rutabaga.c | 47 ++ > > hw/display/virtio-gpu-pci.c | 14 + > > hw/display/virtio-gpu-rutabaga.c | 1119 ++++++++++++++++++++++++++ > > hw/display/virtio-gpu.c | 16 +- > > hw/display/virtio-vga-rutabaga.c | 50 ++ > > hw/display/virtio-vga.c | 33 +- > > hw/virtio/virtio-pci.c | 18 + > > include/hw/virtio/virtio-gpu-bswap.h | 15 + > > include/hw/virtio/virtio-gpu.h | 41 + > > include/hw/virtio/virtio-pci.h | 4 + > > meson.build | 7 + > > meson_options.txt | 2 + > > scripts/meson-buildoptions.sh | 3 + > > softmmu/qdev-monitor.c | 3 + > > softmmu/vl.c | 1 + > > 19 files changed, 1495 insertions(+), 19 deletions(-) > > create mode 100644 docs/system/devices/virtio-gpu.rst > > create mode 100644 hw/display/virtio-gpu-pci-rutabaga.c > > create mode 100644 hw/display/virtio-gpu-rutabaga.c > > create mode 100644 hw/display/virtio-vga-rutabaga.c > > > > -- > > 2.42.0.rc2.253.gd59a3bf2b4-goog > > > --000000000000310d5a0604a68dea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Aug 30, 2023 at 7:26=E2=80=AF= PM Huang Rui <ray.huang@amd.com= > wrote:
On T= ue, Aug 29, 2023 at 08:36:20AM +0800, Gurchetan Singh wrote:
> From: Gurchetan Singh <gurchetansingh@google.com>
>
> Changes since v12:
> - Added r-b tags from Antonio Caggiano and Akihiko Odaki
> - Removed review version from commit messages
> - I think we're good to merge since we've had multiple people = test and review this series??
>
> How to build both rutabaga and gfxstream guest/host libs:
>
> https://crosvm.dev/book/appendix/rutabaga_gfx= .html
>
> Branch containing this patch series:
>
> https://gitlab.com/gurchetan= singh/qemu/-/commits/qemu-gfxstream-v13
>
> Antonio Caggiano (2):
>=C2=A0 =C2=A0virtio-gpu: CONTEXT_INIT feature
>=C2=A0 =C2=A0virtio-gpu: blob prep
>
> Dr. David Alan Gilbert (1):
>=C2=A0 =C2=A0virtio: Add shared memory capability
>
> Gerd Hoffmann (1):
>=C2=A0 =C2=A0virtio-gpu: hostmem

Patch 1 -> 4 are

Acked-and-Tested-by: Huang Rui <ray.huang@amd.com>

Thanks Ray, I've rebased=C2=A0https://gitlab.com/gurchetansingh/= qemu/-/commits/qemu-gfxstream-v13 and added the additional acks in the = commit message.

UI/gfx maintainers, since everythi= ng is reviewed and there hasn't been any additional review comments, ma= y we merge the gfxstream=C2=A0+ rutabaga_gfx series?=C2=A0 Thank you!
=


=C2=A0

>
> Gurchetan Singh (5):
>=C2=A0 =C2=A0gfxstream + rutabaga prep: added need defintions, fields, = and options
>=C2=A0 =C2=A0gfxstream + rutabaga: add initial support for gfxstream >=C2=A0 =C2=A0gfxstream + rutabaga: meson support
>=C2=A0 =C2=A0gfxstream + rutabaga: enable rutabaga
>=C2=A0 =C2=A0docs/system: add basic virtio-gpu documentation
>
>=C2=A0 docs/system/device-emulation.rst=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2= =A0 1 +
>=C2=A0 docs/system/devices/virtio-gpu.rst=C2=A0 =C2=A0|=C2=A0 112 +++ >=C2=A0 hw/display/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 =C2=A022 +
>=C2=A0 hw/display/virtio-gpu-base.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 =C2=A0 6 +-
>=C2=A0 hw/display/virtio-gpu-pci-rutabaga.c |=C2=A0 =C2=A047 ++
>=C2=A0 hw/display/virtio-gpu-pci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A014 +
>=C2=A0 hw/display/virtio-gpu-rutabaga.c=C2=A0 =C2=A0 =C2=A0| 1119 +++++= +++++++++++++++++++++
>=C2=A0 hw/display/virtio-gpu.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 |=C2=A0 =C2=A016 +-
>=C2=A0 hw/display/virtio-vga-rutabaga.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2= =A050 ++
>=C2=A0 hw/display/virtio-vga.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 |=C2=A0 =C2=A033 +-
>=C2=A0 hw/virtio/virtio-pci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 =C2=A018 +
>=C2=A0 include/hw/virtio/virtio-gpu-bswap.h |=C2=A0 =C2=A015 +
>=C2=A0 include/hw/virtio/virtio-gpu.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0= =C2=A041 +
>=C2=A0 include/hw/virtio/virtio-pci.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0= =C2=A0 4 +
>=C2=A0 meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 7 +
>=C2=A0 meson_options.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 2 +
>=C2=A0 scripts/meson-buildoptions.sh=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0= =C2=A0 3 +
>=C2=A0 softmmu/qdev-monitor.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 =C2=A0 3 +
>=C2=A0 softmmu/vl.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 1 +
>=C2=A0 19 files changed, 1495 insertions(+), 19 deletions(-)
>=C2=A0 create mode 100644 docs/system/devices/virtio-gpu.rst
>=C2=A0 create mode 100644 hw/display/virtio-gpu-pci-rutabaga.c
>=C2=A0 create mode 100644 hw/display/virtio-gpu-rutabaga.c
>=C2=A0 create mode 100644 hw/display/virtio-vga-rutabaga.c
>
> --
> 2.42.0.rc2.253.gd59a3bf2b4-goog
>
--000000000000310d5a0604a68dea--