From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FC6CC433F5 for ; Sat, 14 May 2022 04:43:53 +0000 (UTC) Received: from localhost ([::1]:58258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npjd9-0004TT-Sm for qemu-devel@archiver.kernel.org; Sat, 14 May 2022 00:43:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npjc7-0003j4-29 for qemu-devel@nongnu.org; Sat, 14 May 2022 00:42:47 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:55187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npjc1-0005HK-Ea for qemu-devel@nongnu.org; Sat, 14 May 2022 00:42:46 -0400 Received: by mail-wm1-x32d.google.com with SMTP id bg25so5737020wmb.4 for ; Fri, 13 May 2022 21:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NGa8/lAVruqRrohx6drAhUywLz78+FcuUKt7Zac+oMk=; b=F+bi5uioQ6NBAXVZTOmxugE7cDf0OwPBZz1g7eeLZcGoEcK0VWl1a8ED3nxcP6styd mpXkznjLdFYaUBSXl2N6HH6tfpdtj4SBO1RtGFj5o7/8LGAyCJPijVmiltsgG1RE9Yh2 LFR/d1IUbYugUbn6QrYZaxA4N6wqAXXl3sHqJRQRZ8IxYSVja9+9/ITmbeczsiFBwwtG KXzLIBLU6hhG2iXDU/RP+IpeQz2q8f8NDhqEbV0nCxKSUAUGoAyEkKoAjV3vPn4tyOny MIVxvGPAKe04FP0/BO3+80Nv1wPxXz4s1VAjKehbdEJlAR7k/JVqjuv0aOLam/bK6XoA qK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NGa8/lAVruqRrohx6drAhUywLz78+FcuUKt7Zac+oMk=; b=7KYJap0MLagCu0uN9n/gt4FgQnQl5JpcNzRWM5n5rF8u5RoG34KBv1IjqXw73Q+sR2 mlmOp6ZxlVnJEvyKbGrnOGLe0SKrLf7WpdF5RbUEdTciKULjaLOelWGVd63Ms1+4Hy2N K5bWNpQGYzp5On6dgcdRua38CX8ETNmxJ14H6qi/FMMsbF6m6fdU4vvIpPWrxLQUx3DB FVxIV24+udHhPeIeKg6kjc2MqhZxssy1Kc16/lZBlOpEvKjygAosvWoHwVuGomTmKmqg 3AnMlREMOONTrKdbuj6cjD79lWyfCnKzde6uyzBpLjgSQVQeEmHRNk75FYRfhd8lJfMH 5o8w== X-Gm-Message-State: AOAM533rmEZ6uLSAyiK05ocGOgsfjfHdL13l42a383FdV5Ne3JQsm3II 86IrcnImC6xVIJKNyIJfKYcr0CeOfalQ9s0Pgha35g== X-Google-Smtp-Source: ABdhPJyYSqWSgsHWVnO0WFpF+Bgz/YLH/pg3TX49qJCNL7H+s16mPOHfV491YoowaIr4jZVLfaWm64knCBtWQyLHA1M= X-Received: by 2002:a05:600c:5113:b0:394:800c:4c36 with SMTP id o19-20020a05600c511300b00394800c4c36mr7412564wms.93.1652503358874; Fri, 13 May 2022 21:42:38 -0700 (PDT) MIME-Version: 1.0 References: <20220513221458.1192933-1-atishp@rivosinc.com> In-Reply-To: <20220513221458.1192933-1-atishp@rivosinc.com> From: Anup Patel Date: Sat, 14 May 2022 10:12:27 +0530 Message-ID: Subject: Re: [PATCH] hw/intc: Pass correct hartid while updating mtimecmp To: Atish Patra Cc: QEMU Developers , Alistair Francis , "open list:RISC-V" , dylan@rivosinc.com, Bin Meng , Frank Chang , Jim Shu Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2a00:1450:4864:20::32d; envelope-from=anup@brainfault.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, May 14, 2022 at 3:45 AM Atish Patra wrote: > > timecmp update function should be invoked with hartid for which > timecmp is being updated. The following patch passes the incorrect > hartid to the update function. > > Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable") > > Signed-off-by: Atish Patra Looks good to me. Reviewed-by: Anup Patel Regards, Anup > --- > hw/intc/riscv_aclint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c > index 0412edc98257..e6bceceefdbc 100644 > --- a/hw/intc/riscv_aclint.c > +++ b/hw/intc/riscv_aclint.c > @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr, > continue; > } > riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu), > - i, env->timecmp); > + mtimer->hartid_base + i, > + env->timecmp); > } > return; > } > -- > 2.25.1 > >