From: Anup Patel <anup@brainfault.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: "Rahul Pathak" <rpathak@ventanamicro.com>,
"Alistair Francis" <alistair23@gmail.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Anup Patel" <apatel@ventanamicro.com>,
"Rahul Pathak" <rpathakmailbox@gmail.com>,
"Víctor Colombo" <victor.colombo@eldorado.org.br>
Subject: Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid
Date: Wed, 29 Jun 2022 10:00:43 +0530 [thread overview]
Message-ID: <CAAhSdy2DtLs7T2vevBanXxTXV3=c69DAF7u3-F+U-6Mm3qCheQ@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmV45wwZx72y6D2Vcn0VcwtfCRvma574inuCCYw48gCfCg@mail.gmail.com>
On Wed, Jun 29, 2022 at 9:27 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Rahul,
>
> On Wed, Jun 29, 2022 at 10:07 AM Rahul Pathak <rpathak@ventanamicro.com> wrote:
> >
> > Hi Alistair
> >
> > My fix patch needs to be dropped since Anup took care of this issue
> > in his yesterdays series update in this patch -
> > [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec
> > version does not match
>
> I don't understand. Each patch should keep bisectability.
The patches are already bisectable. There was a compile error until
v6 which was fixed in v7 by squashing this patch into PATCH4.
>
> This sounds like to me, that
> [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec
> version does not match
>
> has an issue that it does 2 things: one is to fix this bug, and the
> other one is to force disable extensions.
>
> Which is not right.
The bug is fixed as a result of force disabling extensions which
don't match the priv spec version.
Regards,
Anup
next prev parent reply other threads:[~2022-06-29 4:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 16:40 [PATCH v2] target/riscv: fix user-mode build issue because mhartid Rahul Pathak
2022-06-29 2:01 ` Alistair Francis
2022-06-29 2:07 ` Rahul Pathak
2022-06-29 3:52 ` Bin Meng
2022-06-29 4:30 ` Anup Patel [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-27 16:49 Rahul Pathak
2022-06-27 17:01 ` Rahul Pathak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhSdy2DtLs7T2vevBanXxTXV3=c69DAF7u3-F+U-6Mm3qCheQ@mail.gmail.com' \
--to=anup@brainfault.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=apatel@ventanamicro.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=rpathak@ventanamicro.com \
--cc=rpathakmailbox@gmail.com \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).