From: Anup Patel <anup@brainfault.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Bin Meng <bin.meng@windriver.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Palmer Dabbelt <palmerdabbelt@google.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Anup Patel <Anup.Patel@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>
Subject: Re: [PATCH 2/5] gitlab-ci/opensbi: Update GitLab CI to build generic platform
Date: Sun, 3 May 2020 10:10:44 +0530 [thread overview]
Message-ID: <CAAhSdy3z8ezUx+ozdupR5c5AKLhsfonSFHgrk_Yco2ZH4JubFQ@mail.gmail.com> (raw)
In-Reply-To: <1588348254-7241-3-git-send-email-bmeng.cn@gmail.com>
On Fri, May 1, 2020 at 9:24 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> This updates the GitLab CI opensbi job to build opensbi bios images
> for the generic platform.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> .gitlab-ci-opensbi.yml | 26 ++++++++------------------
> 1 file changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/.gitlab-ci-opensbi.yml b/.gitlab-ci-opensbi.yml
> index dd051c0..26092bb 100644
> --- a/.gitlab-ci-opensbi.yml
> +++ b/.gitlab-ci-opensbi.yml
> @@ -34,18 +34,12 @@ build-opensbi:
> when: always
> artifacts:
> paths: # 'artifacts.zip' will contains the following files:
> - - pc-bios/opensbi-riscv32-sifive_u-fw_jump.bin
> - - pc-bios/opensbi-riscv32-virt-fw_jump.bin
> - - pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin
> - - pc-bios/opensbi-riscv64-virt-fw_jump.bin
> - - opensbi32-virt-stdout.log
> - - opensbi32-virt-stderr.log
> - - opensbi64-virt-stdout.log
> - - opensbi64-virt-stderr.log
> - - opensbi32-sifive_u-stdout.log
> - - opensbi32-sifive_u-stderr.log
> - - opensbi64-sifive_u-stdout.log
> - - opensbi64-sifive_u-stderr.log
> + - pc-bios/opensbi-riscv32-generic-fw_jump.bin
> + - pc-bios/opensbi-riscv64-generic-fw_jump.bin
Same comment as PATCH1
We should add generic-fw_jump.elf here as well.
> + - opensbi32-generic-stdout.log
> + - opensbi32-generic-stderr.log
> + - opensbi64-generic-stdout.log
> + - opensbi64-generic-stderr.log
> image: $CI_REGISTRY_IMAGE:opensbi-cross-build
> variables:
> GIT_DEPTH: 3
> @@ -54,10 +48,6 @@ build-opensbi:
> - export JOBS=$(($(getconf _NPROCESSORS_ONLN) + 1))
> - echo "=== Using ${JOBS} simultaneous jobs ==="
> - make -j${JOBS} -C roms/opensbi clean
> - - make -j${JOBS} -C roms opensbi32-virt 2>&1 1>opensbi32-virt-stdout.log | tee -a opensbi32-virt-stderr.log >&2
> + - make -j${JOBS} -C roms opensbi32-generic 2>&1 1>opensbi32-generic-stdout.log | tee -a opensbi32-generic-stderr.log >&2
> - make -j${JOBS} -C roms/opensbi clean
> - - make -j${JOBS} -C roms opensbi64-virt 2>&1 1>opensbi64-virt-stdout.log | tee -a opensbi64-virt-stderr.log >&2
> - - make -j${JOBS} -C roms/opensbi clean
> - - make -j${JOBS} -C roms opensbi32-sifive_u 2>&1 1>opensbi32-sifive_u-stdout.log | tee -a opensbi32-sifive_u-stderr.log >&2
> - - make -j${JOBS} -C roms/opensbi clean
> - - make -j${JOBS} -C roms opensbi64-sifive_u 2>&1 1>opensbi64-sifive_u-stdout.log | tee -a opensbi64-sifive_u-stderr.log >&2
> + - make -j${JOBS} -C roms opensbi64-generic 2>&1 1>opensbi64-generic-stdout.log | tee -a opensbi64-generic-stderr.log >&2
> --
> 2.7.4
>
>
Otherwise looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
next prev parent reply other threads:[~2020-05-03 4:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 15:50 [PATCH 0/5] riscv: Switch to use generic platform of opensbi bios images Bin Meng
2020-05-01 15:50 ` [PATCH 1/5] roms/opensbi: Update to support building bios images for generic platform Bin Meng
2020-05-03 4:38 ` Anup Patel
2020-05-04 7:16 ` Bin Meng
2020-05-04 7:51 ` Anup Patel
2020-05-04 8:00 ` Bin Meng
2020-05-04 8:04 ` Bin Meng
2020-05-04 8:16 ` Anup Patel
2020-05-04 15:51 ` Alistair Francis
2020-05-06 10:00 ` Bin Meng
2020-05-01 15:50 ` [PATCH 2/5] gitlab-ci/opensbi: Update GitLab CI to build " Bin Meng
2020-05-03 4:40 ` Anup Patel [this message]
2020-05-01 15:50 ` [PATCH 3/5] riscv: Use pre-built bios image of generic platform for virt & sifive_u Bin Meng
2020-05-03 4:43 ` Anup Patel
2020-05-04 15:53 ` Alistair Francis
2020-05-01 15:50 ` [PATCH 4/5] riscv/spike: Change the default bios to use generic platform image Bin Meng
2020-05-03 4:41 ` Anup Patel
2020-05-04 15:54 ` Alistair Francis
2020-05-01 15:50 ` [PATCH 5/5] riscv: Suppress the error report for QEMU testing with riscv_find_firmware() Bin Meng
2020-05-03 4:44 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy3z8ezUx+ozdupR5c5AKLhsfonSFHgrk_Yco2ZH4JubFQ@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmerdabbelt@google.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).