From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88B67E77188 for ; Sat, 4 Jan 2025 20:53:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUB7z-0007VJ-Ts; Sat, 04 Jan 2025 15:52:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUB7s-0007UQ-Em for qemu-devel@nongnu.org; Sat, 04 Jan 2025 15:52:04 -0500 Received: from mail-vk1-xa2c.google.com ([2607:f8b0:4864:20::a2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUB7q-00024z-6p for qemu-devel@nongnu.org; Sat, 04 Jan 2025 15:52:04 -0500 Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-51623968932so7147164e0c.1 for ; Sat, 04 Jan 2025 12:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philjordan-eu.20230601.gappssmtp.com; s=20230601; t=1736023919; x=1736628719; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kFDlTfpF8i6VCYfxZ4G9kev/+B3xmqJOSlU0tdmmlLQ=; b=DxKOLTbz20mHN5Dot0sGFhKVHlzd+hvruQ9XR2ymrCa2DgujcoaStfrWGlIDUnslbp ODK5qawzF+rR2bVKBIgdLGjSQEhdJuBzTrwV7ExhGG5rUUJssnzxHr3bJgq4IesKumne 65EftJ2iHdPqzxRmvOxbSu3vEoAoi2y2jT/JACJXRcg4BvuUQvZ0G4gHlVmariSjNNhN y1bOBdPrVfISjk3oItNigQ+3bIdivqyaJ86f9QSRAAfvMPuxTVzUG5e6ZqNo0MmFs5+V WoGSkGgyelyoF1ATms2aZI4PfmX54CEPpooMxxRnkE5YvX75/CQ4jpHeE3AZQL66rODk gFww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736023919; x=1736628719; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kFDlTfpF8i6VCYfxZ4G9kev/+B3xmqJOSlU0tdmmlLQ=; b=Ni9JyE4rqG96aoFwpqOWF+O8f8BcaQHxJsN0qOLpOg6dG9p/8bKh7Gs2s0knACymMD Y/Hq0etJSKh3OHkLGb9jU14cbJF04FmX//zZerglz2lqR2MHFxrXzfOtiim2msnF/NXR gYIpXrSSzFHOt03SNTUPDUHOIQbt5Zw4ZsYG6/s0GgIbQ1tqCWKBN3DMUXEklP5TYJUA Gzre9Yv1EYT1SZnsKNM2HRC2x70JG8hL6TbvvDlmY67cq8rlBDBlDcSikaVE+KMuCIx0 Eu6iMu4th759e1FbS9R/hFF3su6WGUk5xkdYN8uaKrL1bRjEe7rT5rA83n/8y9qKObht OQNw== X-Forwarded-Encrypted: i=1; AJvYcCUcw62vyBjBmyAUCb5sfAmZB3CvX4ISLwSz+mwtNKuLQmo5e3UHUpzLtx9nvStPiGzwu6ODyL7kPDXk@nongnu.org X-Gm-Message-State: AOJu0Yz27bh00ngLKp5+fDKAze8VDz4u4lzwonLfVkStuaq7Kiq+O4dm 8eWwvOoxl2fO7o1AU8uhFKOqq5EYPa0Oxyk49ybT84uBzZq9zCtjsgeOyTQsxIQU4COwYYz7xwr hDZ1tbs+Yq9TZfW+7Ghg867BscXH4RZ5RVCFO X-Gm-Gg: ASbGnctyjT1VdYP+cRyu6uXgXALGutS8Ksk0IfvNM6My0CYHTlnVvi2Zrs7KzPJnMIM gpsSdU9S6B8acORo54nhnJ+HZ82TS3rNsBeytUw== X-Google-Smtp-Source: AGHT+IGhmVzrrJmOp84f9q27xWcUB6R6Eowc7bZs0e1N02qQ64TWVh4urAng7asPzEQ5UltXLqdGYm74hmrb3HbFYFI= X-Received: by 2002:a05:6122:2519:b0:516:1106:4c1a with SMTP id 71dfb90a1353d-51b75d6b15emr32965434e0c.12.1736023919465; Sat, 04 Jan 2025 12:51:59 -0800 (PST) MIME-Version: 1.0 References: <20241223221645.29911-1-phil@philjordan.eu> <20241223221645.29911-15-phil@philjordan.eu> <2ceda358-adce-42bd-9f29-9a2e441361f0@linaro.org> <34ddf42c-8bb1-4155-90cf-69e1032b0437@daynix.com> In-Reply-To: <34ddf42c-8bb1-4155-90cf-69e1032b0437@daynix.com> From: Phil Dennis-Jordan Date: Sat, 4 Jan 2025 21:51:48 +0100 Message-ID: Subject: Re: [PATCH v16 14/14] hw/vmapple/vmapple: Add vmapple machine type To: Akihiko Odaki Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-devel@nongnu.org, agraf@csgraf.de, peter.maydell@linaro.org, pbonzini@redhat.com, rad@semihalf.com, quic_llindhol@quicinc.com, stefanha@redhat.com, mst@redhat.com, slp@redhat.com, richard.henderson@linaro.org, eduardo@habkost.net, marcel.apfelbaum@gmail.com, gaosong@loongson.cn, jiaxun.yang@flygoat.com, chenhuacai@kernel.org, kwolf@redhat.com, hreitz@redhat.com, shorne@gmail.com, palmer@dabbelt.com, alistair.francis@wdc.com, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, jcmvbkbc@gmail.com, marcandre.lureau@redhat.com, berrange@redhat.com, qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, balaton@eik.bme.hu, Alexander Graf Content-Type: multipart/alternative; boundary="0000000000000ab449062ae7911a" Received-SPF: neutral client-ip=2607:f8b0:4864:20::a2c; envelope-from=phil@philjordan.eu; helo=mail-vk1-xa2c.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --0000000000000ab449062ae7911a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 4 Jan 2025 at 16:15, Akihiko Odaki wrote= : > On 2024/12/28 5:36, Philippe Mathieu-Daud=C3=A9 wrote: > > On 23/12/24 23:16, Phil Dennis-Jordan wrote: > > > >> Known issues: > >> - Keyboard and mouse/tablet input is laggy. The reason for this is > >> that macOS's XHCI driver seems to expect interrupter mapping to > >> be disabled when MSI/MSI-X is unavailable. I have found a > >> workaround but discovered a bunch of other XHCI spec non-complianc= e > >> in the process, so I'm fixing all of those in a separate patch > >> set. > > > > Should we wait for your XHCI fixes series to get reviewed first > > so I can base this series on top (removing this comment) when merging? > > This series no longer cleanly applies due to patches merged early so > please rebase it. > I've already done this locally, but I need to incorporate some of Phil M-D's feedback, I don't think there's much point posting a v17 to the list before those points are resolved. In particular, I'm unsure about part of the proposed fix for the emulated GIC dependency. https://patchew.org/QEMU/20241227202435.48055-1-philmd@linaro.org/202412272= 02435.48055-3-philmd@linaro.org/ I need to set up an aarch64 Linux host to test the build with --enable-kvm --enable-tcg to disprove or confirm my worry that select ARM_GICV3 if !KVM would deselect ARM_GICV3 even though it's needed for the TCG accelerator. And if that suspicion turns out to be correct, I'll need to find a good alternative. select ARM_GICV3 if TCG || HVF || NVMM || WHPX || XEN_EMU || XEN seems=E2=80=A6 awkward. It will be nice if you also: > 1. rebase this vmapple series onto the xHC series and > 2. move "[PATCH v3 6/6] hw/vmapple: XHCI controller's interrupt mapping > workaround for macOS" into this vmapple series > > xHC changes that are not specific to vmapple may be merged early in this > way. I will be also able to test all vmapple code at once. > I'm going to combine the two series and put the generic (standards compliant) XHCI patches first. The final XHCI patch has been squashed into the final vmapple patch. The work-in-progress branch is at https://github.com/pmj/qemu/tree/xhci%2Bvmapple-v17 if you or anyone else wants to test/review. It's currently just a rebase/reorder/squash with conflicts fixed, no functional changes since v16. > Please use Based-on: tag when you post a series that based on another. > It will create a Git tree that I can use for testing at: > https://patchew.org/QEMU/ > docs/devel/submitting-a-patch.rst describes the details. > Thanks! > Regards, > Akihiko Odaki > --0000000000000ab449062ae7911a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Sat, 4 Jan 2025 at 16:15, Akihiko O= daki <akihiko.odaki@daynix.c= om> wrote:
https://patchew.org/QEMU/2024122720= 2435.48055-1-philmd@linaro.org/20241227202435.48055-3-philmd@linaro.org/

I need to set up an aarch64 Linux host to test t= he build with --enable-kvm --enable-tcg to disprove or confirm my worry tha= t=C2=A0
select ARM_GICV3 if !KVM
would deselect ARM= _GICV3 even though it's needed for the TCG accelerator. And if that sus= picion turns out to be correct, I'll need to find a good alternative.
select ARM_GICV3 if TCG || HVF || NVMM || WHPX || XEN_EMU ||=C2=A0= XEN
seems=E2=80=A6 awkward.

It will be nice if you also:
1. rebase this vmapple series onto the xHC series and
2. move "[PATCH v3 6/6] hw/vmapple: XHCI controller's interrupt ma= pping
workaround for macOS" into this vmapple series

xHC changes that are not specific to vmapple may be merged early in this way. I will be also able to test all vmapple code at once.
=

I'm going to combine the two series and put the gen= eric (standards compliant) XHCI=C2=A0 patches first. The final XHCI patch h= as been squashed into the final vmapple patch.

The work-in-progress branch is at https://github.com/pmj/qemu/tree/xhci%2Bvmapple-v17= if you or anyone else wants to test/review. It's currently just a = rebase/reorder/squash with conflicts fixed, no functional changes since v16= .
=C2=A0
Please use Based-on: tag when you post a series that based on another.
It will create a Git tree that I can use for testing at:
= https://patchew.org/QEMU/
docs/devel/submitting-a-patch.rst describes the details.

Thanks!
=C2=A0
Regards,
Akihiko Odaki
--0000000000000ab449062ae7911a--