From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AF23E7718F for ; Sat, 28 Dec 2024 09:58:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRTaJ-0001l7-Io; Sat, 28 Dec 2024 04:58:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRTaF-0001kW-Gq for qemu-devel@nongnu.org; Sat, 28 Dec 2024 04:58:11 -0500 Received: from mail-vs1-xe32.google.com ([2607:f8b0:4864:20::e32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRTaD-0002lc-Fy for qemu-devel@nongnu.org; Sat, 28 Dec 2024 04:58:11 -0500 Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-4aff04f17c7so5060242137.0 for ; Sat, 28 Dec 2024 01:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philjordan-eu.20230601.gappssmtp.com; s=20230601; t=1735379887; x=1735984687; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oLlZkWWkhRX5Oroi9WNUnTbKDBk8JMb0+4tDupX6CDY=; b=u0KbVkNx57iqTt1LN4EPpoWGbg4aCwdoo/9FKdQfHSK2rG9bNqtAmeqjYS4UMZ2CJC qQi8UBRjbOyMWEat80GZk4hB+gdrVfpCZWpOUiZZNEoEnrhBEokEXNziqCKv+bK6EKwk jcXyefKSmLo7aAI6Lkc0Tbsq3Er+9eztKjJo69s9U03wQcDhkF9vLS3aVr4R1AyfQ0gw MNy0Bledc3rUyqF6DVr/Q/q8PQUy2zK1deGeSti3RHr85z7cxNoqspZ4BYdxlwLQz89h w5mdpLJlZ0z1XvZZk1KSVghh/sATyc+HXDwD/qjzSQbG7YPzVF0+O0B0e+ND6gG0UlEp HB1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735379887; x=1735984687; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oLlZkWWkhRX5Oroi9WNUnTbKDBk8JMb0+4tDupX6CDY=; b=Wu92O4UMDe2wXNmT2sCwUHA5OpXwUsWRHVb4bz+kcQDjjhR4guQxFcAqY+Fk3wGEWY 1LO6+Q6sJMcU37+hR+fx5xv15APi/4YdaCKekM2x5vihGCkbZcUXvkFid8dCbLk7DQZp TTYaR7/LxG7BjtU/3z4k8IVzYAi9JykWkd23p6RWRVJjXqDYx4Drhea9I+QeVvJOzpgm IFUGkv7Y/JPvybNl4pd6uvo+aUCvOnB36MSZERMBYWXCWF6yUrFBYN3iIhoTG1YZHb/k yhFPO/UbxFiWoAIN9PjxWNjSJRnmEAc+2bsYNR49VUTPpsprMuRMaI/NCKyiqQpK5TIX yU4A== X-Gm-Message-State: AOJu0YyJv8gwuVliTtL2gKOYT8RU/bpaNrWs5nTezmgDMWCvjOiod6fr +EkXAp7e1ISuBCaEZyfYvHctLa28DG9B3161P3W4ONXeNMTNOejfi7OiIAP+yKjsFpKQW40YYXi qe4QrzelhHiHwkvtxBNVpGQcRLDLKovzGgo1R X-Gm-Gg: ASbGncsqN69I9/QpUUYlN7l6DbtnJXa8OZL719C3EADNXGa85buhmPbE8/OJJEPFqQX eo1D5qpJHkDe6wJleu17RjedbggKXxPvmS0W1uA== X-Google-Smtp-Source: AGHT+IGiSyyfKSDB7Mkz7TcCEBKdAFFFriacETr94JczO/92IwXas/cB+5me+IAbewpOwPTqzqYoe2aIGe/MzeFQVRs= X-Received: by 2002:a05:6102:1623:b0:4b2:9eee:666e with SMTP id ada2fe7eead31-4b2cd6e373bmr22422432137.4.1735379887262; Sat, 28 Dec 2024 01:58:07 -0800 (PST) MIME-Version: 1.0 References: <20241223221645.29911-1-phil@philjordan.eu> <20241223221645.29911-15-phil@philjordan.eu> <2ceda358-adce-42bd-9f29-9a2e441361f0@linaro.org> In-Reply-To: <2ceda358-adce-42bd-9f29-9a2e441361f0@linaro.org> From: Phil Dennis-Jordan Date: Sat, 28 Dec 2024 10:57:56 +0100 Message-ID: Subject: Re: [PATCH v16 14/14] hw/vmapple/vmapple: Add vmapple machine type To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-devel@nongnu.org, agraf@csgraf.de, peter.maydell@linaro.org, pbonzini@redhat.com, rad@semihalf.com, quic_llindhol@quicinc.com, stefanha@redhat.com, mst@redhat.com, slp@redhat.com, richard.henderson@linaro.org, eduardo@habkost.net, marcel.apfelbaum@gmail.com, gaosong@loongson.cn, jiaxun.yang@flygoat.com, chenhuacai@kernel.org, kwolf@redhat.com, hreitz@redhat.com, shorne@gmail.com, palmer@dabbelt.com, alistair.francis@wdc.com, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, jcmvbkbc@gmail.com, marcandre.lureau@redhat.com, berrange@redhat.com, akihiko.odaki@daynix.com, qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, balaton@eik.bme.hu, Alexander Graf Content-Type: multipart/alternative; boundary="000000000000bb2c84062a519dbe" Received-SPF: neutral client-ip=2607:f8b0:4864:20::e32; envelope-from=phil@philjordan.eu; helo=mail-vs1-xe32.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --000000000000bb2c84062a519dbe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 27 Dec 2024 at 21:36, Philippe Mathieu-Daud=C3=A9 wrote: > On 23/12/24 23:16, Phil Dennis-Jordan wrote: > > > Known issues: > > - Keyboard and mouse/tablet input is laggy. The reason for this is > > that macOS's XHCI driver seems to expect interrupter mapping to > > be disabled when MSI/MSI-X is unavailable. I have found a > > workaround but discovered a bunch of other XHCI spec non-compliance > > in the process, so I'm fixing all of those in a separate patch > > set. > > Should we wait for your XHCI fixes series to get reviewed first > so I can base this series on top (removing this comment) when merging? > I guess that depends on timing to some extent. Maintaining all these patches out-of-tree for extended periods of time is somewhat tedious. We could also merge this series in batches if that's preferable? The gpex patch (4/15) especially touches a lot of parts of the code base, so I'd really like that to get wider regression testing sooner rather than later. Patches 1-5 are also useful outside of the vmapple machine type, as they affect x86-64 macOS guests, so they could easily be merged without the rest. (OK the apple-gfx-mmio variant contained in 2/14 is only useful for vmapple; if we were being picky, it could easily be separated out into a separate patch to be merged with the rest of vmapple though.) --000000000000bb2c84062a519dbe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, 27 Dec = 2024 at 21:36, Philippe Mathieu-Daud=C3=A9 <philmd@linaro.org> wrote:
On 23/12/24 23:16, Phil Dennis-Jordan wrote:

> Known issues:
>=C2=A0 =C2=A0- Keyboard and mouse/tablet input is laggy. The reason for= this is
>=C2=A0 =C2=A0 =C2=A0that macOS's XHCI driver seems to expect interr= upter mapping to
>=C2=A0 =C2=A0 =C2=A0be disabled when MSI/MSI-X is unavailable. I have f= ound a
>=C2=A0 =C2=A0 =C2=A0workaround but discovered a bunch of other XHCI spe= c non-compliance
>=C2=A0 =C2=A0 =C2=A0in the process, so I'm fixing all of those in a= separate patch
>=C2=A0 =C2=A0 =C2=A0set.

Should we wait for your XHCI fixes series to get reviewed first
so I can base this series on top (removing this comment) when merging?
<= /blockquote>

I guess that depends on timing to some exte= nt. Maintaining all these patches out-of-tree for extended periods of time = is somewhat tedious. We could also merge this series in batches if that= 9;s preferable?

The gpex patch (4/15) especially t= ouches a lot of parts of the code base, so I'd really like that to get= wider regression testing sooner rather than later.

Patches 1-5 are also useful outside of the vmapple machine type, as t= hey affect x86-64 macOS guests, so they could easily be merged without the = rest. (OK the apple-gfx-mmio variant contained in 2/14 is only useful for v= mapple; if we were being picky, it could easily be separated out into a sep= arate patch to be merged with the rest of vmapple though.)
--000000000000bb2c84062a519dbe--