From: Phil Dennis-Jordan <phil@philjordan.eu>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition
Date: Fri, 5 Jul 2024 12:52:00 +0200 [thread overview]
Message-ID: <CAAibmn3GHALkLnG_BXSLZOKrVzKTkU0zWJSQNkGCe-+BLvOZ5g@mail.gmail.com> (raw)
In-Reply-To: <20240627-cursor-v2-3-c3cd3ee35616@daynix.com>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
I've just tried to rebase my own patches on top of this work and noticed
the following typo:
On Thu, 27 Jun 2024 at 13:17, Akihiko Odaki <akihiko.odaki@daynix.com>
wrote:
> static void cocoa_refresh(DisplayChangeListener *dcl);
> +static void cocoa_mouse_set(DisplayChangeListener *dcl, int x, int y, int
> on);
The above prototype does not match the below definition - note the type
mismatch on the last parameter:
+static void cocoa_mouse_set(DisplayChangeListener *dcl, int x, int y, bool
> on)
> +{
> + dispatch_async(dispatch_get_main_queue(), ^{
> + [cocoaView setMouseX:x y:y on:on];
> + });
> +}
>
[-- Attachment #2: Type: text/html, Size: 1155 bytes --]
next prev parent reply other threads:[~2024-07-05 10:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 11:17 [PATCH v2 0/4] ui/cocoa: Add cursor composition Akihiko Odaki
2024-06-27 11:17 ` [PATCH v2 1/4] ui/cocoa: Release CGColorSpace Akihiko Odaki
2024-07-02 11:58 ` Phil Dennis-Jordan
2024-06-27 11:17 ` [PATCH v2 2/4] ui/console: Convert mouse visibility parameter into bool Akihiko Odaki
2024-06-29 12:18 ` Marc-André Lureau
2024-07-02 12:00 ` Phil Dennis-Jordan
2024-06-27 11:17 ` [PATCH v2 3/4] ui/cocoa: Add cursor composition Akihiko Odaki
2024-07-02 13:19 ` Phil Dennis-Jordan
2024-07-02 14:20 ` Philippe Mathieu-Daudé
2024-07-02 14:25 ` Phil Dennis-Jordan
2024-07-02 16:19 ` Philippe Mathieu-Daudé
2024-07-05 10:52 ` Phil Dennis-Jordan [this message]
2024-06-27 11:17 ` [PATCH v2 4/4] ui/console: Remove dpy_cursor_define_supported() Akihiko Odaki
2024-06-29 12:21 ` Marc-André Lureau
2024-07-02 13:20 ` Phil Dennis-Jordan
2024-07-06 20:49 ` [PATCH v2 0/4] ui/cocoa: Add cursor composition Phil Dennis-Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAibmn3GHALkLnG_BXSLZOKrVzKTkU0zWJSQNkGCe-+BLvOZ5g@mail.gmail.com \
--to=phil@philjordan.eu \
--cc=akihiko.odaki@daynix.com \
--cc=berrange@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).