From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] rust: pl011: fix warning with new clippy
Date: Fri, 10 Oct 2025 15:24:50 +0300 [thread overview]
Message-ID: <CAAjaMXYocRnv-TFFw8nBSsLDihooVNoM_VGrFNeeq5-9YVNdSw@mail.gmail.com> (raw)
In-Reply-To: <20251009211148.642966-1-pbonzini@redhat.com>
On Fri, Oct 10, 2025 at 12:12 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Newer versions of clippy are able to see that all the variants in
> the PL011 word length enum end with "Bits", and complain about it.
> Allow it.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> rust/hw/char/pl011/src/registers.rs | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rust/hw/char/pl011/src/registers.rs b/rust/hw/char/pl011/src/registers.rs
> index 0c3a4d7d214..fa572811b29 100644
> --- a/rust/hw/char/pl011/src/registers.rs
> +++ b/rust/hw/char/pl011/src/registers.rs
> @@ -255,6 +255,7 @@ pub enum Mode {
>
> #[bitsize(2)]
> #[derive(Clone, Copy, Debug, Eq, FromBits, PartialEq)]
> +#[allow(clippy::enum_variant_names)]
> /// `WLEN` Word length, field of [Line Control register](LineControl).
> ///
> /// These bits indicate the number of data bits transmitted or received in a
> --
> 2.51.0
>
>
prev parent reply other threads:[~2025-10-10 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 21:11 [PATCH] rust: pl011: fix warning with new clippy Paolo Bonzini
2025-10-10 12:24 ` Manos Pitsidianakis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAjaMXYocRnv-TFFw8nBSsLDihooVNoM_VGrFNeeq5-9YVNdSw@mail.gmail.com \
--to=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).