Re: [PATCH] tests/functional: Switch back to the gitlab URLs for the advent calendar tests

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 2177 bytes --]

On Tue, Oct 1, 2024, 12:14 PM Thomas Huth <thuth@redhat.com> wrote:

> On 01/10/2024 10.50, Manos Pitsidianakis wrote:
> > Hello Thomas,
> >
> > On Mon, 30 Sep 2024 20:18, Thomas Huth <thuth@redhat.com> wrote:
> >> Shortly after we switched to the original URLs on
> qemu-advent-calendar.org,
> >> the server went offline - looks like we are better off using the gitlab
> >> URLs again instead.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >> ---
> > [snip]
> >> diff --git a/tests/functional/test_microblazeel_s3adsp1800.py b/tests/
> >> functional/test_microblazeel_s3adsp1800.py
> >> index faa3927f2e..47c941d487 100755
> >> --- a/tests/functional/test_microblazeel_s3adsp1800.py
> >> +++ b/tests/functional/test_microblazeel_s3adsp1800.py
> >> @@ -18,8 +18,8 @@ class MicroblazeelMachine(QemuSystemTest):
> >>     timeout = 90
> >>
> >>     ASSET_IMAGE = Asset(
> >> -        ('
> http://www.qemu-advent-calendar.org/2023/download/day13.tar.gz'),
> >> -
> 'b9b3d43c5dd79db88ada495cc6e0d1f591153fe41355e925d791fbf44de50c22')
> >> +        ('
> https://qemu-advcal.gitlab.io/qac-best-of-multiarch/download/
> >> day13.tar.xz'),
> >> +
> '67e4c502651f8801e724ecc26403f1d0cdbc00549b033166e2e8cd14e9d49fef')
> >>
> >>     def test_microblazeel_s3adsp1800(self):
> >>         self.require_netdev('user')
> >
> > I downloaded both day13.tar.gz and day13.tar.xz and these archives have
> > different file contents, is that on purpose?
>
> Oh, drat! That's a different package, indeed - it's the one from 2018, not
> the one from 2023! I didn't really notice since I did not remove my
> tests/functional/ folder before re-running the tests, so this test was
> silently re-using the old binary from the previous test runs :-/
> (note to myself: we should maybe remove the binaries after each test run).
>
> Thanks for spotting it!
>
> Meanwhile, the www.qemu-advent-calendar.org website seems to be back, so
> maybe we don't need this patch here anymore... let's wait and see whether
> it
> remains stable now...


Suggestion: Add a list of source URLs in Asset() so that it has a fallback
if the first host cannot be reached, maybe you can respin the patch to do
this?

[-- Attachment #2: Type: text/html, Size: 3521 bytes --]