From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F064CCA472 for ; Wed, 8 Oct 2025 14:05:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v6Um1-0004WT-DL; Wed, 08 Oct 2025 10:04:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6Ulq-0004VA-4y for qemu-devel@nongnu.org; Wed, 08 Oct 2025 10:03:59 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v6Ulf-0002QL-IN for qemu-devel@nongnu.org; Wed, 08 Oct 2025 10:03:57 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-637dbabdb32so14918958a12.2 for ; Wed, 08 Oct 2025 07:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759932224; x=1760537024; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z0olP/2AkIkCDMmo015JOmyflycM0in2cEbggeW9smg=; b=aibz1kcSNWuMqoSPtrvsErqg6MXjWG/k2G0pas2S85u6r98/ROnmn+Fk0NFTY4q3Ie 9lIwUPXBZiHosNnzYYs6ZVsYEsxRXWn5UKXKLESymr4QizcVZHsgQdThK//1dpZodiuI l40T347M0fpJSmVXQvl6xfJaKNtUioVrIHvcymarVVUO96G2hRbMUQ+vqFNP6WDELw9H cEVUR1cNs2TmP9rzz5P/D8omirT6MQ5OPGXYVhJuG8ZLzAflsgX/qRXW1oPa/Ja8TFU2 xyZsonp6eSqtOPpHXaWkjy0gwBhUSHMAZFfl8/GgSoiCQJOuPL2Zt62TKhP2X3w6rbz1 jGnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759932224; x=1760537024; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z0olP/2AkIkCDMmo015JOmyflycM0in2cEbggeW9smg=; b=MhuNQ/mtZkC5zyW/ox2Kt5ZpVyprj5IVgnJti11J4FfolO+ZlOz/g80ITsuwQ5KvaX CWLdWahADRAmMYb1XqsjOuipKE+HJfr2zlafLBQ4Suw55mIHpjRngNbao3SCtopTx8YJ OHoFEEARzBxWILQkBDRsldQCmJE5WN27W8IbJ6Ywv9oSVhxBNG4Es8fR9L/lj2sufHsx aOZlyNcTP7cD3J12xFTqdgetBmEXJVMCaDOX05JGaZOT/t1Zd3LLo168SUfPa1vLgsgq XhN+d/hdBGHSB01XN5XcKSMQF2PV19oHrX4jOSOCwvfur6TNjzTfCcMbkrundAeFLgBB r8oQ== X-Gm-Message-State: AOJu0YxLX2VuQDToV/iDOb93UWC3o46uZicXOl+UHl5KMIuTnozDAKgp LlNnfGmm+yqv9/kMl83JlVFc7sK+gQSl0zNUelernM/wi9CPo2zBhTEoTqmLqtllDUbT0Dtc/R+ hVxbIr/LBfzaUjA4LQ8Qy1TWcrO9PhogyWFQtb9COKw== X-Gm-Gg: ASbGncstTP6LboWxuk8jzOoVsSC9qn1s/MA7nl1cEivU0xN64MgsFfDFxZojBbCK1dW 0e+l7hZTrabOrku060RzWFapLd7uaVCKJGZ34IXST6Zz+6ly0PDRT4McaiEGjbAkd80qhr8U9RV cK5vUIsdn4wCd4A+TRJLdhWYnF0D6UZNVNVVYH4O9ILFDluAsy3zcomlcbZt8ricc0ImapKKwiA rdA1X/pzwLUg1esEsyCq831bsNwVhMn X-Google-Smtp-Source: AGHT+IET969eLX4reQPZNvdzkK62iF3KSCeI2CYxfVPVUF046E/jybKgqgDgNh8RA5mk6xUUocjg6SVW2lo30nq5ktg= X-Received: by 2002:a05:6402:1ed2:b0:639:d9de:3c59 with SMTP id 4fb4d7f45d1cf-639d9de3ddamr2690009a12.5.1759932224120; Wed, 08 Oct 2025 07:03:44 -0700 (PDT) MIME-Version: 1.0 References: <20251002145742.75624-1-philmd@linaro.org> <20251002145742.75624-3-philmd@linaro.org> In-Reply-To: <20251002145742.75624-3-philmd@linaro.org> From: Manos Pitsidianakis Date: Wed, 8 Oct 2025 17:03:18 +0300 X-Gm-Features: AS18NWD5b0CqjAHLEmoCaNuUxfgbmOMV-LNi6IphdCC3_xSvOrkzk5qMVdHYhfA Message-ID: Subject: Re: [PATCH 2/6] target/i386/monitor: Replace legacy cpu_physical_memory_read() calls To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-devel@nongnu.org, Alistair Francis , qemu-riscv@nongnu.org, Max Filippov , Liu Zhiwei , Weiwei Li , Zhao Liu , Paolo Bonzini , Artyom Tarasenko , Daniel Henrique Barboza , Palmer Dabbelt , Mark Cave-Ayland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 2, 2025 at 6:00=E2=80=AFPM Philippe Mathieu-Daud=C3=A9 wrote: > > Commit b7ecba0f6f6 ("docs/devel/loads-stores.rst: Document our > various load and store APIs") mentioned cpu_physical_memory_*() > methods are legacy, the replacement being address_space_*(). > > Replace: > > - cpu_physical_memory_read(len=3D4) -> address_space_ldl() > - cpu_physical_memory_read(len=3D8) -> address_space_ldq() > > inlining the little endianness conversion via the '_le' suffix. > As with the previous implementation, ignore whether the memory > read succeeded or failed. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- Reviewed-by: Manos Pitsidianakis