From: Zavadovsky Yan <zavadovsky.yan@gmail.com>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Weil <sw@weilnetz.de>,
Olivier Hainque <hainque@adacore.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails
Date: Thu, 2 Jul 2015 22:09:31 +0300 [thread overview]
Message-ID: <CAAkiskh=BhU=TCiTon6EX7nQCr70EqREe8hxTGzrV4FKpdWRVQ@mail.gmail.com> (raw)
In-Reply-To: <55956C5C.6080107@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
I tested this patch on my 4-cores cpu.
Debug and release builds both.
Win32 and Win64 binaries both. (I used old Fedora 17-18 with SJLJ mingw-w64
to crossbuild for Win64.)
With default Qemu BIOS and with myself-builded OVMF(also debug and
release) from EDK2.
Also I did some synthetic tests with sample from this article:
http://blogs.msdn.com/b/oldnewthing/archive/2015/02/05/10591215.aspx
modified as I described here:
http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg06894.html
On Thu, Jul 2, 2015 at 7:52 PM, Fabien Chouteau <chouteau@adacore.com>
wrote:
> On 07/01/2015 08:00 PM, Stefan Weil wrote:
> > Am 01.07.2015 um 18:49 schrieb Paolo Bonzini:
> >>
> >> On 01/07/2015 17:48, Zavadovsky Yan wrote:
> >>> Ping.
> >> Stefan, are you merging this?
> >>
> >> Paolo
> >
> > I can do so, but as the current code seems to fix the problems
> > with multi-processor systems, too (even if it is unclear why),
> > it does not look urgent.
> >
> > Fabien, you suggested "extensive tests". Do you think that
> > patch v2 is fine, or are you still waiting for test results?
> >
>
> The patch looks good. I won't be able to do heavy testing anytime soon,
> if Yan tells us that the new code was tested I will take his word for it.
>
> Thanks,
>
>
[-- Attachment #2: Type: text/html, Size: 2378 bytes --]
next prev parent reply other threads:[~2015-07-02 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 12:25 [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails Zavadovsky Yan
2015-06-25 9:11 ` Olga Krishtal
2015-06-25 12:17 ` Zavadovsky Yan
2015-06-26 10:28 ` Olga Krishtal
2015-06-26 11:03 ` Zavadovsky Yan
2015-07-01 15:48 ` Zavadovsky Yan
2015-07-01 16:49 ` Paolo Bonzini
2015-07-01 17:00 ` Liviu Ionescu
2015-07-01 18:00 ` Stefan Weil
2015-07-02 16:52 ` Fabien Chouteau
2015-07-02 19:09 ` Zavadovsky Yan [this message]
2015-07-06 9:29 ` Fabien Chouteau
2015-07-14 19:44 ` Zavadovsky Yan
2015-07-14 20:29 ` Stefan Weil
2015-07-14 20:32 ` Zavadovsky Yan
2015-09-10 20:06 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAkiskh=BhU=TCiTon6EX7nQCr70EqREe8hxTGzrV4FKpdWRVQ@mail.gmail.com' \
--to=zavadovsky.yan@gmail.com \
--cc=chouteau@adacore.com \
--cc=hainque@adacore.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).