From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAjrc-0007ja-64 for qemu-devel@nongnu.org; Thu, 02 Jul 2015 15:09:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAjra-000316-PY for qemu-devel@nongnu.org; Thu, 02 Jul 2015 15:09:36 -0400 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:35945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAjra-00030K-Cx for qemu-devel@nongnu.org; Thu, 02 Jul 2015 15:09:34 -0400 Received: by lagc2 with SMTP id c2so67381627lag.3 for ; Thu, 02 Jul 2015 12:09:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <55956C5C.6080107@adacore.com> References: <1435148753-4476-1-git-send-email-zavadovsky.yan@gmail.com> <55941A03.8040803@redhat.com> <55942AD1.1040906@weilnetz.de> <55956C5C.6080107@adacore.com> Date: Thu, 2 Jul 2015 22:09:31 +0300 Message-ID: From: Zavadovsky Yan Content-Type: multipart/alternative; boundary=001a11c30f86e765ca0519e92d6c Subject: Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: Peter Maydell , Stefan Weil , Olivier Hainque , qemu-devel@nongnu.org, Paolo Bonzini --001a11c30f86e765ca0519e92d6c Content-Type: text/plain; charset=UTF-8 I tested this patch on my 4-cores cpu. Debug and release builds both. Win32 and Win64 binaries both. (I used old Fedora 17-18 with SJLJ mingw-w64 to crossbuild for Win64.) With default Qemu BIOS and with myself-builded OVMF(also debug and release) from EDK2. Also I did some synthetic tests with sample from this article: http://blogs.msdn.com/b/oldnewthing/archive/2015/02/05/10591215.aspx modified as I described here: http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg06894.html On Thu, Jul 2, 2015 at 7:52 PM, Fabien Chouteau wrote: > On 07/01/2015 08:00 PM, Stefan Weil wrote: > > Am 01.07.2015 um 18:49 schrieb Paolo Bonzini: > >> > >> On 01/07/2015 17:48, Zavadovsky Yan wrote: > >>> Ping. > >> Stefan, are you merging this? > >> > >> Paolo > > > > I can do so, but as the current code seems to fix the problems > > with multi-processor systems, too (even if it is unclear why), > > it does not look urgent. > > > > Fabien, you suggested "extensive tests". Do you think that > > patch v2 is fine, or are you still waiting for test results? > > > > The patch looks good. I won't be able to do heavy testing anytime soon, > if Yan tells us that the new code was tested I will take his word for it. > > Thanks, > > --001a11c30f86e765ca0519e92d6c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I tested this= patch on my 4-cores cpu.
Debug and release builds both.
Win32 and Win64 binaries both. (I used old Fedora 17-18 with SJLJ min= gw-w64 to crossbuild for Win64.)
With default Qemu BIOS and with myself-builded OVMF(also debug and r= elease)=C2=A0from EDK2.
Also I did some synthet= ic tests with sample from this article:
modified as I described here:

On Thu, Jul 2, 2015 at 7:52 PM, Fabien = Chouteau <chouteau@adacore.com> wrote:
On 07/01/2015 08:00= PM, Stefan Weil wrote:
> Am 01.07.2015 um 18:49 schrieb Paolo Bonzini:
>>
>> On 01/07/2015 17:48, Zavadovsky Yan wrote:
>>> Ping.
>> Stefan, are you merging this?
>>
>> Paolo
>
> I can do so, but as the current code seems to fix the problems
> with multi-processor systems, too (even if it is unclear why),
> it does not look urgent.
>
> Fabien, you suggested "extensive tests". Do you think that > patch v2 is fine, or are you still waiting for test results?
>

The patch looks good. I won't be able to do heavy testing a= nytime soon,
if Yan tells us that the new code was tested I will take his word for it.
Thanks,


--001a11c30f86e765ca0519e92d6c--