[Qemu-devel] [PATCH v2] linux-user: pass correct host flags to accept4()

[Qemu-devel] [PATCH v2] linux-user: pass correct host flags to accept4()

[Petar Jovanovic]

From: Petar Jovanovic <petar.jovanovic@imgtec.com>

Flags NONBLOCK and CLOEXEC can have different values on the host and the
guest, so set correct host values before calling accept4().

This fixes several issues with accept4 system call and user-mode of QEMU.

Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---

 v2:
 - use target_to_host_bitmask() (per comment from Peter Maydell)

 linux-user/syscall.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 2eac6d5..9864813 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2062,9 +2062,12 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
     socklen_t addrlen;
     void *addr;
     abi_long ret;
+    int host_flags;
+
+    host_flags = target_to_host_bitmask(flags, fcntl_flags_tbl);
 
     if (target_addr == 0) {
-        return get_errno(accept4(fd, NULL, NULL, flags));
+        return get_errno(accept4(fd, NULL, NULL, host_flags));
     }
 
     /* linux returns EINVAL if addrlen pointer is invalid */
@@ -2080,7 +2083,7 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
 
     addr = alloca(addrlen);
 
-    ret = get_errno(accept4(fd, addr, &addrlen, flags));
+    ret = get_errno(accept4(fd, addr, &addrlen, host_flags));
     if (!is_error(ret)) {
         host_to_target_sockaddr(target_addr, addr, addrlen);
         if (put_user_u32(addrlen, target_addrlen_addr))
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH v2] linux-user: pass correct host flags to accept4()

[Peter Maydell]

On 31 March 2014 16:41, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Flags NONBLOCK and CLOEXEC can have different values on the host and the
> guest, so set correct host values before calling accept4().
>
> This fixes several issues with accept4 system call and user-mode of QEMU.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [PATCH v2] linux-user: pass correct host flags to accept4()

[Riku Voipio]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi,

Applied to my for-2.0 branch,

Thanks



On 31 March 2014 18:45, Peter Maydell <peter.maydell@linaro.org> wrote:

> On 31 March 2014 16:41, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> > From: Petar Jovanovic <petar.jovanovic@imgtec.com>
> >
> > Flags NONBLOCK and CLOEXEC can have different values on the host and the
> > guest, so set correct host values before calling accept4().
> >
> > This fixes several issues with accept4 system call and user-mode of QEMU.
> >
> > Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM
>

[-- Attachment #2: Type: text/html, Size: 1293 bytes --]