From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42931)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SQzI1-0006zP-IU
	for qemu-devel@nongnu.org; Sun, 06 May 2012 07:06:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SQzHy-0005P3-CA
	for qemu-devel@nongnu.org; Sun, 06 May 2012 07:06:09 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:56519)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SQzHy-0005Of-5E
	for qemu-devel@nongnu.org; Sun, 06 May 2012 07:06:06 -0400
Received: by yenm4 with SMTP id m4so1062982yen.4
	for <qemu-devel@nongnu.org>; Sun, 06 May 2012 04:06:04 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4FA55EAA.3020605@suse.de>
References: <1334412060-1595-1-git-send-email-andreas.faerber@web.de>
	<4F899BBB.1050604@web.de> <4F8BCAC6.7000101@redhat.com>
	<4FA55EAA.3020605@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 6 May 2012 11:05:44 +0000
Message-ID: <CAAu8pHs3nPOYLpzP7yfH_hKzqOS-HYYWGetMORuh46rvyYBvmA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] OpenBSD build (was: [PATCH v2] os-posix: Fix build
 on FreeBSD)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Brad Smith <brad@comstyle.com>

On Sat, May 5, 2012 at 5:08 PM, Andreas F=C3=A4rber <afaerber@suse.de> wrot=
e:
> Am 16.04.2012 09:31, schrieb Gerd Hoffmann:
>> Don't have FreeBSD at hand. =C2=A0/me has a OpenBSD virtual machine for =
build
>> tests where this code compiles without issues.
> [snip]
>
> I've now set up an OpenBSD 5.1 VM and it compiles okay. However the
> output is completely chatty due to redundant declarations in the OpenBSD
> system headers.
>
> When I remove -Wredundant-decls from QEMU_CFLAGS it is much better.
>
> Any suggestion how to properly fix this in configure? The QEMU_CFLAGS
> block is before the OS has been checked, and fwiw the flag has been
> around since 2008 (e0e36fe91d2eadcec8159eb6d728c9dd7fc6cf44 / r5931).

Can we have a check whether system headers produce warnings, something
like this:
$ cat headers.c
#include <sys/types.h>
#include <unistd.h>
$ gcc -Wredundant-decls -c headers.c
In file included from headers.c:2:
/usr/include/unistd.h:100: warning: redundant redeclaration of 'lseek'
/usr/include/sys/types.h:210: warning: previous declaration of 'lseek' was =
here
/usr/include/unistd.h:139: warning: redundant redeclaration of 'ftruncate'
/usr/include/sys/types.h:211: warning: previous declaration of
'ftruncate' was here
/usr/include/unistd.h:164: warning: redundant redeclaration of 'truncate'
/usr/include/sys/types.h:212: warning: previous declaration of
'truncate' was here

>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=
=BCrnberg