From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SU1Le-0005uu-D6
	for qemu-devel@nongnu.org; Mon, 14 May 2012 15:54:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SU1Lb-0008HS-S2
	for qemu-devel@nongnu.org; Mon, 14 May 2012 15:54:25 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:39433)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1SU1Lb-0008H7-Lb
	for qemu-devel@nongnu.org; Mon, 14 May 2012 15:54:23 -0400
Received: by yhoo21 with SMTP id o21so5974795yho.4
	for <qemu-devel@nongnu.org>; Mon, 14 May 2012 12:54:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4FB12FA8.8050109@suse.de>
References: <1336608892-30501-1-git-send-email-afaerber@suse.de>
	<4FB12FA8.8050109@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 14 May 2012 19:54:00 +0000
Message-ID: <CAAu8pHsde4z_3RxdTWOw2obsQiXA8ZXxc==R0JrBRgs7CbuAXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState,
	part 3: CPU reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, May 14, 2012 at 4:15 PM, Andreas F=C3=A4rber <afaerber@suse.de> wro=
te:
> Am 10.05.2012 02:13, schrieb Andreas F=C3=A4rber:
>> Andreas F=C3=A4rber (74):
> [...]
>> =C2=A0 target-sparc: Let cpu_sparc_init() return SPARCCPU
>> =C2=A0 sun4m: Use cpu_sparc_init() to obtain SPARCCPU
>> =C2=A0 sun4m: Pass SPARCCPU to {main,secondary}_cpu_reset()
>> =C2=A0 sun4u: Use cpu_sparc_init() to obtain SPARCCPU
>> =C2=A0 sun4u: Let cpu_devinit() return SPARCCPU
>> =C2=A0 sun4u: Store SPARCCPU in ResetData
>> =C2=A0 leon3: Use cpu_sparc_init() to obtain SPARCCPU
>> =C2=A0 leon3: Store SPARCCPU in ResetData
> [...]
>> =C2=A0 Kill off cpu_state_reset()
>
> Ping! Blue, can you ack please?

What was again the purpose of all these changes, 00/74 only mentions
killing cpu_state_reset()? For example two CPU types (SPARCCPU vs.
CPUSPARCState) doesn't look very useful, is that needed?

Otherwise the patches look pretty safe ("if it compiles, it works").

>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=
=BCrnberg