From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50126)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1RRlUI-0004Od-8b
	for qemu-devel@nongnu.org; Sat, 19 Nov 2011 09:01:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1RRlUH-00063r-15
	for qemu-devel@nongnu.org; Sat, 19 Nov 2011 09:01:46 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:60838)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1RRlUG-00063m-TY
	for qemu-devel@nongnu.org; Sat, 19 Nov 2011 09:01:44 -0500
Received: by ghbg19 with SMTP id g19so707137ghb.4
	for <qemu-devel@nongnu.org>; Sat, 19 Nov 2011 06:01:44 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4EC0E159.2030906@adacore.com>
References: <1320333464-12967-1-git-send-email-chouteau@adacore.com>
	<CAAu8pHuLQeks7eaJr_fa99LFx=Qfh9i_hepim8E6miJuQvBcRA@mail.gmail.com>
	<4EC0E159.2030906@adacore.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 19 Nov 2011 14:01:23 +0000
Message-ID: <CAAu8pHt34YPi2ShV4mykFaLZ60Z2qMCSfdKe7Jb0oFqukb_pWQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] [SPARC] Improve "ta 0" shutdown
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-devel@nongnu.org

On Mon, Nov 14, 2011 at 09:37, Fabien Chouteau <chouteau@adacore.com> wrote:
> On 13/11/2011 10:43, Blue Swirl wrote:
>> On Thu, Nov 3, 2011 at 15:17, Fabien Chouteau <chouteau@adacore.com> wrote:
>>> This patch replace the previous implementation with this simplified and
>>> more complete version (no shutdown when psret == 1).
>>
>> In order to get in 1.0, the change should be limited to adding only a
>> psret check to current helper_shutdown(). This way it should be also
>> possible to retain the CPU feature check in translation time instead
>> of pushing it to do_interrupt path, so it should be a better for
>> performance anyway.
>>
>
> The purpose of this feature is to know when we get to this error state
> (trap when interrupts disabled), if we abort with an error message or
> just shutdown the emulator. In any case it's the end of the emulation,
> it happens only once, so performance is not important here.

Right, so I applied this as is, thanks.

> For 1.0, I can do another intermediate patch.
>
> --
> Fabien Chouteau
>