From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49203)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Rw9Ot-0007pw-E9
	for qemu-devel@nongnu.org; Sat, 11 Feb 2012 04:37:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Rw9Os-0003fh-4B
	for qemu-devel@nongnu.org; Sat, 11 Feb 2012 04:37:47 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:61553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Rw9Or-0003fd-Qq
	for qemu-devel@nongnu.org; Sat, 11 Feb 2012 04:37:45 -0500
Received: by iahk25 with SMTP id k25so1693921iah.4
	for <qemu-devel@nongnu.org>; Sat, 11 Feb 2012 01:37:45 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1328799563-18932-1-git-send-email-afaerber@suse.de>
References: <1328799563-18932-1-git-send-email-afaerber@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 11 Feb 2012 09:37:25 +0000
Message-ID: <CAAu8pHtmrbxXMwcZFNXyMuL6oQUJ6aoQTboVVYJ3RTu9HaiN_A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing
	spaces in audio files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Feb 9, 2012 at 14:59, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Disable warnings for spaces before opening parenthesis in
> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: malc <av1474@comtv.ru>
> ---
> =C2=A0scripts/checkpatch.pl | =C2=A0 =C2=A05 +++++
> =C2=A01 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 8850a5f..5433736 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -246,6 +246,8 @@ our $allowed_asm_includes =3D qr{(?x:
> =C2=A0)};
> =C2=A0# memory.h: ARM has a custom one
>
> +our $audio_files =3D qr{hw/ac97.c|hw/adlib.c|hw/cs4231a.c|hw/es1370.c|hw=
/gus.c|hw/sb16.c};
> +
> =C2=A0sub build_types {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0my $mods =3D "(?x: =C2=A0\n" . join("|\n =C2=
=A0", @modifierList) . "\n)";
> =C2=A0 =C2=A0 =C2=A0 =C2=A0my $all =3D "(?x: =C2=A0\n" . join("|\n =C2=A0=
", @typeList) . "\n)";
> @@ -1966,6 +1968,9 @@ sub process {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0asm|__asm__)$/x)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0{
>
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 # malc wants to keep spacing consistent in the audio files.
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 } elsif ($realfile =3D~ /($audio_files)/) {
> +
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0# cpp #define statements have non-optional spaces, ie
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0# if there is a space between the name and the open
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0# parenthesis it is simply not a parameter group.
> --
> 1.7.7
>

NACK to such special casing.