* [Qemu-devel] [PATCH] virtio-pci: add missing 'static'
@ 2012-05-12 19:47 Blue Swirl
2012-05-12 21:04 ` Stefan Weil
0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2012-05-12 19:47 UTC (permalink / raw)
To: Anthony Liguori, qemu-devel
There are no outside references to virtio_portio.
Add missing 'static' specifier.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
hw/virtio-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index 4a4413d..8a931ce 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -491,7 +491,7 @@ static void virtio_pci_config_writel(void *opaque,
uint32_t addr, uint32_t val)
virtio_config_writel(proxy->vdev, addr, val);
}
-const MemoryRegionPortio virtio_portio[] = {
+static const MemoryRegionPortio virtio_portio[] = {
{ 0, 0x10000, 1, .write = virtio_pci_config_writeb, },
{ 0, 0x10000, 2, .write = virtio_pci_config_writew, },
{ 0, 0x10000, 4, .write = virtio_pci_config_writel, },
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-pci: add missing 'static'
2012-05-12 19:47 [Qemu-devel] [PATCH] virtio-pci: add missing 'static' Blue Swirl
@ 2012-05-12 21:04 ` Stefan Weil
2012-05-12 21:35 ` Blue Swirl
2012-05-19 19:01 ` Blue Swirl
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2012-05-12 21:04 UTC (permalink / raw)
To: Blue Swirl; +Cc: Anthony Liguori, qemu-devel
Am 12.05.2012 21:47, schrieb Blue Swirl:
> There are no outside references to virtio_portio.
> Add missing 'static' specifier.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> hw/virtio-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 4a4413d..8a931ce 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -491,7 +491,7 @@ static void virtio_pci_config_writel(void *opaque,
> uint32_t addr, uint32_t val)
line was wrapped
> virtio_config_writel(proxy->vdev, addr, val);
> }
>
> -const MemoryRegionPortio virtio_portio[] = {
> +static const MemoryRegionPortio virtio_portio[] = {
> { 0, 0x10000, 1, .write = virtio_pci_config_writeb, },
> { 0, 0x10000, 2, .write = virtio_pci_config_writew, },
> { 0, 0x10000, 4, .write = virtio_pci_config_writel, },
terminating "---" and git version missing
Reviewed-by: Stefan Weil <sw@weilnetz.de>
The patch is fine, but your mailer reformats the patch:
it cannot by applied with "git am" without manual corrections.
Regards,
Stefan W.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-pci: add missing 'static'
2012-05-12 21:04 ` Stefan Weil
@ 2012-05-12 21:35 ` Blue Swirl
2012-05-19 19:01 ` Blue Swirl
1 sibling, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2012-05-12 21:35 UTC (permalink / raw)
To: Stefan Weil; +Cc: Anthony Liguori, qemu-devel
On Sat, May 12, 2012 at 9:04 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Am 12.05.2012 21:47, schrieb Blue Swirl:
>
>> There are no outside references to virtio_portio.
>> Add missing 'static' specifier.
>>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> ---
>> hw/virtio-pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>> index 4a4413d..8a931ce 100644
>> --- a/hw/virtio-pci.c
>> +++ b/hw/virtio-pci.c
>> @@ -491,7 +491,7 @@ static void virtio_pci_config_writel(void *opaque,
>> uint32_t addr, uint32_t val)
>
>
> line was wrapped
>
>
>> virtio_config_writel(proxy->vdev, addr, val);
>> }
>>
>> -const MemoryRegionPortio virtio_portio[] = {
>> +static const MemoryRegionPortio virtio_portio[] = {
>> { 0, 0x10000, 1, .write = virtio_pci_config_writeb, },
>> { 0, 0x10000, 2, .write = virtio_pci_config_writew, },
>> { 0, 0x10000, 4, .write = virtio_pci_config_writel, },
>
>
> terminating "---" and git version missing
Those are visible here:
http://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg01751.html
>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
Thanks for the review.
> The patch is fine, but your mailer reformats the patch:
> it cannot by applied with "git am" without manual corrections.
>
> Regards,
> Stefan W.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-pci: add missing 'static'
2012-05-12 21:04 ` Stefan Weil
2012-05-12 21:35 ` Blue Swirl
@ 2012-05-19 19:01 ` Blue Swirl
1 sibling, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2012-05-19 19:01 UTC (permalink / raw)
To: Stefan Weil; +Cc: Anthony Liguori, qemu-devel
On Sat, May 12, 2012 at 9:04 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Am 12.05.2012 21:47, schrieb Blue Swirl:
>
>> There are no outside references to virtio_portio.
>> Add missing 'static' specifier.
>>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> ---
>> hw/virtio-pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>> index 4a4413d..8a931ce 100644
>> --- a/hw/virtio-pci.c
>> +++ b/hw/virtio-pci.c
>> @@ -491,7 +491,7 @@ static void virtio_pci_config_writel(void *opaque,
>> uint32_t addr, uint32_t val)
>
>
> line was wrapped
>
>
>> virtio_config_writel(proxy->vdev, addr, val);
>> }
>>
>> -const MemoryRegionPortio virtio_portio[] = {
>> +static const MemoryRegionPortio virtio_portio[] = {
>> { 0, 0x10000, 1, .write = virtio_pci_config_writeb, },
>> { 0, 0x10000, 2, .write = virtio_pci_config_writew, },
>> { 0, 0x10000, 4, .write = virtio_pci_config_writel, },
>
>
> terminating "---" and git version missing
>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> The patch is fine, but your mailer reformats the patch:
> it cannot by applied with "git am" without manual corrections.
Applied.
>
> Regards,
> Stefan W.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-19 19:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-12 19:47 [Qemu-devel] [PATCH] virtio-pci: add missing 'static' Blue Swirl
2012-05-12 21:04 ` Stefan Weil
2012-05-12 21:35 ` Blue Swirl
2012-05-19 19:01 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).