From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFQmc-00013h-MG for qemu-devel@nongnu.org; Sat, 22 Sep 2012 10:34:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFQmb-0003NZ-IW for qemu-devel@nongnu.org; Sat, 22 Sep 2012 10:34:14 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:34456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFQmb-0003NV-DQ for qemu-devel@nongnu.org; Sat, 22 Sep 2012 10:34:13 -0400 Received: by iea17 with SMTP id 17so2989540iea.4 for ; Sat, 22 Sep 2012 07:34:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120921162428.GS16157@illuin> References: <1348236465-23124-1-git-send-email-mdroth@linux.vnet.ibm.com> <505C8E76.1030104@redhat.com> <20120921162428.GS16157@illuin> From: Blue Swirl Date: Sat, 22 Sep 2012 14:33:52 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: Paolo Bonzini , aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org, peter.maydell@linaro.org On Fri, Sep 21, 2012 at 4:24 PM, Michael Roth wrote: > On Fri, Sep 21, 2012 at 05:57:42PM +0200, Paolo Bonzini wrote: >> Il 21/09/2012 16:07, Michael Roth ha scritto: >> > >> > QIDL_DECLARE(SerialDevice) { >> > SysBusDevice parent; >> > >> > uint8_t thr; /* transmit holding register */ >> > uint8_t lsr; /* line status register */ >> > uint8_t ier; /* interrupt enable register */ >> > >> > int int_pending qDerived; /* whether we have a pending queued interrupt */ >> > CharDriverState *chr qImmutable; /* backend */ >> > }; >> >> I thought we agreed on QIDL(derived), QIDL(immutable) etc. These >> prefixes just do not scale... > > qImmutable gets defined as QIDL(immutable) via qidl.h, and underneath > the covers it's all QIDL(). So we can change them easily if need be, and > still have the optional of using QIDL() for any current or new > annotations that get introduced. But QIDL() just ends up being > really noisey in practice, especially when a field has multiple > annotations, so I'd like to make that kind of usage the exceptional > case rather than the common one. > > I went with qUppercase because it avoids all the previous issues with > using leading underscores, and it's reserved in terms of QEMU coding > guidelines as far as I can tell (we generally require leading capital > for typedefs and lowercase for variable names, and can work around > exceptions on a case by case basis by using QIDL() or some other name). > I also had it as q_* for a bit but that didn't seem much better on the > eyes we looking at converted structures. It looks like Hungarian notation and very much unlike other QEMU code. I'd use q_ or qidl_ prefix instead, or rather QIDL(). > >> >> Paolo >>