From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T35Cf-0006Po-1Q for qemu-devel@nongnu.org; Sun, 19 Aug 2012 09:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T35Cd-0005fx-Rl for qemu-devel@nongnu.org; Sun, 19 Aug 2012 09:06:04 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:47360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T35Cd-0005fY-L8 for qemu-devel@nongnu.org; Sun, 19 Aug 2012 09:06:03 -0400 Received: by iakx26 with SMTP id x26so1796546iak.4 for ; Sun, 19 Aug 2012 06:06:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <502A2D26.4060702@redhat.com> <502CBC26.9030705@redhat.com> <5030BC1D.90801@redhat.com> From: Blue Swirl Date: Sun, 19 Aug 2012 13:05:42 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Avi Kivity , Anthony Liguori , liu ping fan On Sun, Aug 19, 2012 at 12:03 PM, Peter Maydell wrote: > On 19 August 2012 12:23, Peter Maydell wrote: >> Ideally, yes, but qemu is full of devices that haven't yet made the leap >> to QOM. >> >> omap1 is particularly tricky because I don't actually have any test images >> for it, so refactoring it is a leap in the dark. [I've tried asking on this list >> if anybody had test images a couple of times without success.] > > As an aside, maybe we should just delete the omap1 code if we haven't > got any way of testing it? Yes, for example start printing warnings when the machine is started to solicit new maintainers. We should apply the same logic elsewhere too. > > -- PMM >