From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7uNC-0007kB-29 for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:00:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7uN9-00081F-Sb for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:00:37 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:35586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7uN9-00080z-KZ for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:00:35 -0400 Received: by iafj26 with SMTP id j26so3062951iaf.4 for ; Wed, 14 Mar 2012 13:00:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4F5F5C7E.5040701@codemonkey.ws> References: <4F5E58BE.6040808@weilnetz.de> <4F5E5C49.6060900@codemonkey.ws> <4F5F4E3B.5040306@redhat.com> <4F5F52F8.1060601@codemonkey.ws> <4F5F5BC8.3060704@redhat.com> <4F5F5C7E.5040701@codemonkey.ws> From: Blue Swirl Date: Wed, 14 Mar 2012 20:00:13 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] We need more reviewers/maintainers!! List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , Stefano Stabellini , Avi Kivity , qemu-devel@nongnu.org On Tue, Mar 13, 2012 at 14:41, Anthony Liguori wrot= e: > On 03/13/2012 09:38 AM, Avi Kivity wrote: >> >> On 03/13/2012 04:00 PM, Anthony Liguori wrote: >>> >>> On 03/13/2012 08:40 AM, Avi Kivity wrote: >>>> >>>> On 03/12/2012 10:27 PM, Anthony Liguori wrote: >>>>>> >>>>>> I agree that more maintainers would be good, but we also need >>>>>> more people with commit rights. >>>>> >>>>> >>>>> I disagree strongly. =C2=A0Having multiple pushers makes things diffi= cult >>>>> and encourages people to push without testing. =C2=A0Part of what mak= es >>>>> pushing take longer than it should today is that my test cycle takes >>>>> at least 1-2 hours and it's not uncommon to have to go through 3-4 >>>>> cycles of rebasing before being able to push. >>>> >>>> >>>> This really sucks. >>>> >>>> If testing was automated, we could have a staging branch where >>>> maintainers would push patches, they'd get tested automatically and th= en >>>> graduate to master. =C2=A0The workflow would look something like >>>> >>>> =C2=A0 =C2=A0git fetch >>>> =C2=A0 =C2=A0git checkout staging >>>> =C2=A0 =C2=A0git rebase origin/staging >>>> =C2=A0 =C2=A0 >>>> =C2=A0 =C2=A0git push staging >>>> =C2=A0 =C2=A0 >>>> =C2=A0 =C2=A0>>> from the test system> >>> >>> >>> The problem for me with this is that I test before I do a thorough >>> review. =C2=A0I do a quick review, but not a line-by-line review. =C2= =A0So I >>> don't necessarily want to queue for push. >> >> >> Seems to me it's better to review before testing, no? > > > I typically do a high level review before queuing for testing, but I don'= t > do a line-by-line review for coding style or minor issues. > > The later must be done before committing no matter how many revisions are > sent. =C2=A0It's more time efficient to catch a functional problem withou= t doing > the line-by-line review. =C2=A0Best case scenario is that the line-by-lin= e review > happens only once for a patch before it's committed. Perhaps patchwork is not the right tool for this. Coreboot uses Gerrit: http://review.coreboot.org/#/q/status:open,n,z combined with Jenkins build bot. This looks much more professional. >>>> If testing cannot be automated, perhaps a lock around the tree would >>>> help. >>> >>> >>> I think merging qemu-test into make check would help a lot. =C2=A0If al= l >>> committers are running the same test suite before pushing, then this >>> problem would become less common. =C2=A0It's livable now because most >>> committers commit infrequently. >>> >>> But if we added more committers, it would become pretty problematic. >> >> >> I'm not arguing either for or against that, just trying to make the >> commit process more efficient. > > > Yup, and appreciate the suggestions. > > Regards, > > Anthony Liguori > > >