From: chen huacai <zltjiangshi@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Huacai Chen" <chenhuacai@gmail.com>,
qemu-level <qemu-devel@nongnu.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Huacai Chen" <chenhc@lemote.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 06/12] hw/pci-host/bonito: Fix DPRINTF() format strings
Date: Mon, 11 May 2020 09:20:30 +0800 [thread overview]
Message-ID: <CABDp7VqY1v8AiJbM8_owP5wk1ZBODDTNsZVjkxdhtmfuhufq+g@mail.gmail.com> (raw)
In-Reply-To: <20200510210128.18343-7-f4bug@amsat.org>
Reviewed-by: Huacai Chen <chenhc@lemote.com>
On Mon, May 11, 2020 at 5:07 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/pci-host/bonito.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c
> index b9bfe3c417..10ead31e4f 100644
> --- a/hw/pci-host/bonito.c
> +++ b/hw/pci-host/bonito.c
> @@ -239,7 +239,7 @@ static void bonito_writel(void *opaque, hwaddr addr,
>
> saddr = addr >> 2;
>
> - DPRINTF("bonito_writel "TARGET_FMT_plx" val %x saddr %x\n",
> + DPRINTF("bonito_writel "TARGET_FMT_plx" val %lx saddr %x\n",
> addr, val, saddr);
> switch (saddr) {
> case BONITO_BONPONCFG:
> @@ -327,7 +327,7 @@ static void bonito_pciconf_writel(void *opaque, hwaddr addr,
> PCIBonitoState *s = opaque;
> PCIDevice *d = PCI_DEVICE(s);
>
> - DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %x\n", addr, val);
> + DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %lx\n", addr, val);
> d->config_write(d, addr, val, 4);
> }
>
> @@ -474,7 +474,7 @@ static void bonito_spciconf_write(void *opaque, hwaddr addr, uint64_t val,
> uint32_t pciaddr;
> uint16_t status;
>
> - DPRINTF("bonito_spciconf_write "TARGET_FMT_plx" size %d val %x\n",
> + DPRINTF("bonito_spciconf_write "TARGET_FMT_plx" size %d val %lx\n",
> addr, size, val);
>
> pciaddr = bonito_sbridge_pciaddr(s, addr);
> --
> 2.21.3
>
>
--
Huacai Chen
next prev parent reply other threads:[~2020-05-11 1:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 21:01 [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot Philippe Mathieu-Daudé
2020-05-10 21:01 ` [PATCH 01/12] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer Philippe Mathieu-Daudé
2020-05-11 5:46 ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 02/12] hw/mips/fuloong2e: Rename PMON BIOS name Philippe Mathieu-Daudé
2020-05-11 1:14 ` chen huacai
2020-05-10 21:01 ` [PATCH 03/12] hw/mips/fuloong2e: Move code and update a comment Philippe Mathieu-Daudé
2020-05-11 1:15 ` chen huacai
2020-05-10 21:01 ` [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name Philippe Mathieu-Daudé
2020-05-11 1:19 ` chen huacai
2020-05-11 6:21 ` Aleksandar Markovic
2020-05-11 6:38 ` Philippe Mathieu-Daudé
2020-05-11 7:00 ` chen huacai
2020-05-11 8:12 ` Aleksandar Markovic
2020-05-11 8:27 ` Aleksandar Markovic
2020-05-12 8:09 ` Philippe Mathieu-Daudé
2020-05-10 21:01 ` [PATCH 05/12] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge Philippe Mathieu-Daudé
2020-05-11 1:19 ` chen huacai
2020-05-10 21:01 ` [PATCH 06/12] hw/pci-host/bonito: Fix DPRINTF() format strings Philippe Mathieu-Daudé
2020-05-11 1:20 ` chen huacai [this message]
2020-05-10 21:01 ` [PATCH 07/12] hw/pci-host/bonito: Map peripheral using physical address Philippe Mathieu-Daudé
2020-05-11 5:50 ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 08/12] hw/pci-host/bonito: Map all the Bonito64 I/O range Philippe Mathieu-Daudé
2020-05-11 5:51 ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 09/12] hw/pci-host/bonito: Map the different PCI ranges more detailled Philippe Mathieu-Daudé
2020-05-11 6:12 ` Aleksandar Markovic
2020-05-11 6:33 ` Philippe Mathieu-Daudé
2020-05-10 21:01 ` [PATCH 10/12] hw/pci-host/bonito: Better describe the I/O CS regions Philippe Mathieu-Daudé
2020-05-11 5:53 ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 11/12] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32 Philippe Mathieu-Daudé
2020-05-11 6:17 ` Aleksandar Markovic
2020-05-11 6:30 ` Philippe Mathieu-Daudé
2020-05-11 7:16 ` Aleksandar Markovic
2020-05-10 21:01 ` [NOTFORMERGE PATCH 12/12] POC hw/pci-host/bonito: Fix BONGENCFG value after a warm-reset Philippe Mathieu-Daudé
2020-05-11 9:43 ` [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot Aleksandar Markovic
2020-05-26 7:47 ` Philippe Mathieu-Daudé
2020-05-26 10:41 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABDp7VqY1v8AiJbM8_owP5wk1ZBODDTNsZVjkxdhtmfuhufq+g@mail.gmail.com \
--to=zltjiangshi@gmail.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).