From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cem0b-0000H8-SN for qemu-devel@nongnu.org; Fri, 17 Feb 2017 12:07:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cem0a-0005tB-RU for qemu-devel@nongnu.org; Fri, 17 Feb 2017 12:07:49 -0500 MIME-Version: 1.0 In-Reply-To: References: <1933406e-2576-e687-3545-a72f3b999310@redhat.com> <20170217064327.GB21716@lemon.lan> <6ab86cf8-4780-ca76-f648-ac0ce211e27b@redhat.com> From: Chad Joan Date: Fri, 17 Feb 2017 12:07:25 -0500 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Eric Blake , Peter Maydell , Fam Zheng , QEMU Trivial , Laszlo Ersek , QEMU Developers How wonderful! Problem solved. Now I think that just having an example could kill the misconception forever ;) On Fri, Feb 17, 2017 at 11:57 AM, Paolo Bonzini wrote: > > > On 17/02/2017 17:54, Chad Joan wrote: > > Regarding the signature: IIRC, setting up certificates on a machine > > using gpg can be quite time consuming and learning-intensive if you've > > never needed to do it before. Having that example will go a long way to > > help with this. There is still a possible pain-point: you might write > > one line of git code in the example, and it is easy for you due to your > > workflow, but it could be hours of fiddling for someone who has never > > done it before. If I'm wrong, show me (the hypothetical reader) how > > easy it is ;) If I'm right (and that would be unfortunate, in this > > case), then it might be helpful if you politely ask the reader to spend > > time X amount of time on it (establish accurate expectations) and then > > provide a link to the most helpful how-to article you can find on the > > subject. > > GPG signing is not needed. All you need is "git commit -s". > > Adding "Signed-off-by: Chad Joan " basically is a > way to tell us "I understand I'm contributing this under the GNU GPL or > a compatible license". It's not a cryptographic signature. > > Paolo >